[PM-29256] - add premium spotlight feature flag

[jaasen-livefront]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-29256

📔 Objective

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[claude]

Claude finished @jaasen-livefront's task —— View job

---

Code Review Complete ✅

Tasks

• Read the changed file (src/Core/Constants.cs)
• Review the git diff to see exact changes
• Analyze feature flag naming and implementation
• Provide comprehensive code review feedback

---

Review Summary

This PR adds a new feature flag constant BrowserPremiumSpotlight to the FeatureFlagKeys class in src/Core/Constants.cs. The change is minimal, well-placed, and follows established patterns in the codebase.

Detailed Feedback

✅ What's Good

1. Naming Convention: The constant name BrowserPremiumSpotlight follows the established PascalCase naming pattern used throughout the FeatureFlagKeys class.

2. Value Format: The value "pm-23384-browser-premium-spotlight" correctly follows the team's convention of using kebab-case with the Jira ticket number prefix.

3. Placement: The constant is appropriately placed in the /* Vault Team */ section alongside other vault-related feature flags, maintaining logical organization.

4. Consistency: The PR follows the pattern of other feature flag additions in the codebase.

5. Minimal Change: The PR scope is appropriately narrow - adding only the feature flag constant without unnecessary changes.

📝 Observations

1. No Tests Required: Feature flag constants are declarative string values that are automatically discovered via reflection (see GetAllKeys() method on line 268). No additional unit tests are needed for this change.

2. Automatic Discovery: The GetAllKeys() method uses reflection to find all public static string fields, so this new constant will automatically be included in the list of available feature flags.

3. Team Assignment: This flag is correctly placed under the /* Vault Team */ section, which aligns with the ticket number prefix and the feature name.

ℹ️ Additional Context

The feature flag follows Bitwarden's feature flag pattern where:

• The constant name is descriptive and identifies the feature
• The value matches the Jira ticket format (pm-XXXXX-description)
• The flag will be used to control the rollout of the "browser premium spotlight" feature
• No breaking changes are introduced

Recommendation

✅ Approve - This is a clean, straightforward addition that follows all established conventions. The change is ready to merge once CI passes.

---

[github-actions]

Checkmarx One – Scan Summary & Details – 06062268-9263-4fc9-afd1-08df23543fba

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.48%. Comparing base (de5a81b) to head (9111f5b).
⚠️ Report is 24 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6693      +/-   ##
==========================================
+ Coverage   53.40%   53.48%   +0.07%     
==========================================
  Files        1910     1918       +8     
  Lines       85115    85563     +448     
  Branches     7640     7678      +38     
==========================================
+ Hits        45455    45761     +306     
- Misses      37909    38031     +122     
- Partials     1751     1771      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.