Skip to content

Conversation

@trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Dec 6, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-28337

📔 Objective

Removes pm-23174-manage-account-recovery-permission-drives-the-need-to-set-master-password feature flag and flagged logic on the server. There was no flagged client-side logic for this feature.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@trmartin4 trmartin4 changed the title Remove feature flag [PM-28337] Remove feature flag Dec 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2025

Logo
Checkmarx One – Scan Summary & Details9533de50-8818-4601-ba52-d0d0da94281c

Great job! No new security vulnerabilities introduced in this pull request

Base automatically changed from auth/pm-28331/remove-pm-24425-send-2fa-failed-email to main December 8, 2025 18:42
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.63%. Comparing base (bd75c71) to head (039c0ae).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6698      +/-   ##
==========================================
- Coverage   53.63%   53.63%   -0.01%     
==========================================
  Files        1926     1926              
  Lines       85717    85704      -13     
  Branches     7686     7684       -2     
==========================================
- Hits        45977    45965      -12     
- Misses      37967    37969       +2     
+ Partials     1773     1770       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants