Remove FF: pm-22415-tax-id-warnings

[amorask-bitwarden]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-28541

📔 Objective

Feature flag is unused in server.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[claude]

Claude finished @amorask-bitwarden's task —— View job

---

Code Review Complete ✓

Tasks

• Gather context and understand PR changes
• Perform thorough code review using bitwarden-code-reviewer
• Post review findings

---

Review Summary

Overall Assessment: ✅ APPROVE

This PR cleanly removes an unused feature flag constant with no impact on functionality.

Findings

Feature Flag Verification:

• ✅ Confirmed PM22415_TaxIDWarnings is completely unused in the server codebase
• ✅ Zero references found in source code, tests, or configuration files
• ✅ The actual tax ID warning feature remains operational and doesn't depend on this constant

Historical Context:

• The feature flag was introduced in PR [PM-22415] Tax ID notifications for Organizations and Providers #6185 (commit bd133b9) on August 18, 2025
• The flag appears to have never been actively used in the implementation
• Tax ID warning functionality has evolved in subsequent PRs (PM-25205, PM-24350) without needing this feature flag

Code Quality:

• Simple, focused change removing a single unused constant from src/Core/Constants.cs:189
• No security, performance, or compatibility implications
• No test updates needed (no tests reference this constant)
• Proper cleanup of technical debt

Conclusion

This is a straightforward removal of an unused feature flag constant. The change is safe, complete, and requires no additional cleanup. The underlying tax ID warning functionality continues to work independently of this constant.

👍 Ready to merge once CI passes.

---

[github-actions]

Checkmarx One – Scan Summary & Details – 28a85cee-3ce9-4a91-a95d-c08c5e48458c

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.63%. Comparing base (acc2529) to head (62efd3b).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6709      +/-   ##
==========================================
- Coverage   53.63%   53.63%   -0.01%     
==========================================
  Files        1926     1926              
  Lines       85717    85717              
  Branches     7686     7686              
==========================================
- Hits        45978    45977       -1     
- Misses      37966    37967       +1     
  Partials     1773     1773              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.