🔨 Suppress bad unreachable diagnostic

MSVC somehow determines that some code is "unreachable" despite
actually being reachable code.

The bad diagnostics have been suppressed.

Author: bitwizeshift

include/bpstd/detail/config.hpp

@@ -86,7 +86,7 @@
 # define BPSTD_COMPILER_DIAGNOSTIC_PREAMBLE \
   __pragma(warning(push)) \
   __pragma(warning(disable:4714)) \
-  __pragma(warning(disable:4100))
+  __pragma(warning(disable:4100)) 
 #else
 # define BPSTD_COMPILER_DIAGNOSTIC_PREAMBLE
 #endif

include/bpstd/detail/variant_base.hpp

@@ -190,17 +190,26 @@ bpstd::detail::variant_base<false,Types...>::variant_base()
 
 }
 
+#if defined(_MSC_VER)
+# pragma warning(push)
+# pragma warning(disable:4702)
+#endif
+
 template <typename...Types>
 template <std::size_t N, typename...Args>
 inline BPSTD_INLINE_VISIBILITY constexpr
 bpstd::detail::variant_base<false,Types...>::variant_base(variant_index_tag<N>,
-                                                         Args&&...args)
+                                                          Args&&...args)
   : m_union{variant_index_tag<N>{}, std::forward<Args>(args)...},
     m_index{N}
 {
 
 }
 
+#if defined(_MSC_VER)
+# pragma warning(pop)
+#endif
+
 //------------------------------------------------------------------------------
 
 template <typename...Types>

test/src/bpstd/variant.test.cpp

@@ -22,6 +22,13 @@
   SOFTWARE.
 */
 
+// MSVC 2015 seems to emit "unreachable code" diagnostics in the wrong function
+// whenever a function is inlined. The error will not be seen in the inlined
+// function, but it may be seen in the surrounding scope of the inlined function
+#if defined(_MSC_VER)
+# pragma warning(disable:4702)
+#endif
+
 #include <bpstd/variant.hpp>
 #include <bpstd/memory.hpp>
 
@@ -37,6 +44,7 @@
 // stupid reason.
 #if defined(_MSC_VER)
 # pragma warning(disable:4714)
+# pragma warning(disable:4702)
 #endif
 
 static_assert(