Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make choice of BA.2 "reference" at root more robust #5

Open
jbloom opened this issue Aug 15, 2022 · 3 comments
Open

make choice of BA.2 "reference" at root more robust #5

jbloom opened this issue Aug 15, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@jbloom
Copy link
Collaborator

jbloom commented Aug 15, 2022

Right now the spike for the reference is hardcoded into the script Trevor generated (81e43a2#diff-54f0382e7ad5485edc0f8936ebc650ad9a30d03bd39bcd4e0b1080800bf757afR15-R17), which doesn't seem ideal. How do we make this better and read from data?

@jbloom jbloom added the enhancement New feature or request label Aug 15, 2022
@trvrb
Copy link
Member

trvrb commented Aug 15, 2022

Right now, we're using SouthAfrica/NHLS-UCT-LA-Z957/2022 as basal BA.2. This manifests in multiple locations:

Data files:

  • data/ba2_outgroup_metadata.tsv
  • data/ba2_outgroup_sequences/fasta
refine:
  root: "SouthAfrica/NHLS-UCT-LA-Z957/2022"

in escape_profiles/escape/builds.yaml

reference is set in escape_profiles/escape/sequence_to_escape.py. I grabbed this from the workflow artifact results/escape/translations/aligned.gene.S.fasta

@trvrb
Copy link
Member

trvrb commented Aug 15, 2022

I'm actually not very worried about having to have multiple places where this shows up. However, it would be good to make sure that this is a properly basal BA.2 virus.

@jbloom
Copy link
Collaborator Author

jbloom commented Aug 16, 2022

Sounds good. Is there a recommended way to determine what is a good basal BA.2 virus?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants