Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge firefox-selection-fix #32

Open
allo- opened this issue Jun 2, 2021 · 5 comments
Open

Merge firefox-selection-fix #32

allo- opened this issue Jun 2, 2021 · 5 comments
Labels
Env::Linux Issues on Linux Env::Mac Issues on Mac Install Problems in the installation process Issue::Enhancement New feature or request

Comments

@allo-
Copy link

allo- commented Jun 2, 2021

Since some time, Firefox has the annoying feature to select the text in the URL bar, when you click it. There is a fix here:
https://github.com/SebastianSimon/firefox-selection-fix

It looks like you could merge your projects into some project that allows to select which features to restore trying to maintain several fixes to the Firefox UI, that were created when the changes were introduced.

@black7375
Copy link
Owner

Awesome.
It's definitely worth a try and looks good.
It should be included in the next release.

@black7375 black7375 added Issue::Enhancement New feature or request Env::Linux Issues on Linux Env::Mac Issues on Mac Install Problems in the installation process labels Jun 2, 2021
@black7375
Copy link
Owner

It also helps when merging branch/interactive-js later.

Main use cases of this branch (Just concepts)

  • Fluent Tab Hover Effect Roadmap #2 (comment)
  • Restore Bookmark Animation
  • Restore Page Action & Screenshot
  • Battery Saver
  • ...

@ojaha065
Copy link

ojaha065 commented Jun 2, 2021

It should be included in the next release.

Personally I think that Firefox default behaviour selecting the whole URL when clicked is fine. I'm used to it working that way and wouldn't like it to change. But I totally understand why some people hate that feature. (Which is exactly why it was a foolish decision by Mozilla to remove the browser.urlbar.clickSelectsAll option.)

My point being that if something like this is implemented or merged to this project, it shouldn't be enabled by default and/or there should be an easy way to disable it.

@ghost
Copy link

ghost commented Jun 2, 2021

@ojaha065 Me too. I'll implement prompting the user for selection.

@black7375
Copy link
Owner

black7375 commented Jun 2, 2021

@ojaha065 That's right. I think it's a possibility to activate the option and install it.

I prefer the full clickSelectsAll feature and have no intention of changing the default value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Env::Linux Issues on Linux Env::Mac Issues on Mac Install Problems in the installation process Issue::Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants