Merge rust-bitcoin/corepc#212: Implement getconnectioncount method and test

2408e45a7154e487e08ee24c591e4b23729d1a5d Implement getconnectioncount method and test (GideonBature)

Pull request description:

  The JSON-RPC method `getconnectioncount` does return a numeric. We want to test this to catch any changes in behavior in future Core versions.

  This PR adds a client function that errors if the return value is anything other than `numeric`, along with an integration test that calls this function.

  Ref: [#116](rust-bitcoin/corepc#116)

ACKs for top commit:
  tcharding:
    ACK 2408e45a7154e487e08ee24c591e4b23729d1a5d

Tree-SHA512: 8fadbbe57fe567daebe150cf76cce96d0693ee1763bd8bbfafe4b736751da8dc42b2681aeccf7eb8fbc03083a2ecb131ee59ffc24608ea20ec3693b944477147

Author: blaze-smith470pm

client/src/client_sync/v17/mod.rs

@@ -75,6 +75,7 @@ crate::impl_client_v17__add_node!();
 crate::impl_client_v17__clear_banned!();
 crate::impl_client_v17__disconnect_node!();
 crate::impl_client_v17__get_added_node_info!();
+crate::impl_client_v17__get_connection_count!();
 crate::impl_client_v17__get_net_totals!();
 crate::impl_client_v17__get_network_info!();
 crate::impl_client_v17__get_peer_info!();

client/src/client_sync/v17/network.rs

@@ -69,6 +69,18 @@ macro_rules! impl_client_v17__get_added_node_info {
     };
 }
 
+/// Implements Bitcoin Core JSON-RPC API method `getconnectioncount`
+#[macro_export]
+macro_rules! impl_client_v17__get_connection_count {
+    () => {
+        impl Client {
+            pub fn get_connection_count(&self) -> Result<GetConnectionCount> {
+                self.call("getconnectioncount", &[])
+            }
+        }
+    };
+}
+
 /// Implements Bitcoin Core JSON-RPC API method `getnettotals`
 #[macro_export]
 macro_rules! impl_client_v17__get_net_totals {

client/src/client_sync/v18/mod.rs

@@ -79,6 +79,7 @@ crate::impl_client_v17__add_node!();
 crate::impl_client_v17__clear_banned!();
 crate::impl_client_v17__disconnect_node!();
 crate::impl_client_v17__get_added_node_info!();
+crate::impl_client_v17__get_connection_count!();
 crate::impl_client_v17__get_net_totals!();
 crate::impl_client_v17__get_network_info!();
 crate::impl_client_v18__get_node_addresses!();

client/src/client_sync/v19/mod.rs

@@ -77,6 +77,7 @@ crate::impl_client_v17__add_node!();
 crate::impl_client_v17__clear_banned!();
 crate::impl_client_v17__disconnect_node!();
 crate::impl_client_v17__get_added_node_info!();
+crate::impl_client_v17__get_connection_count!();
 crate::impl_client_v17__get_net_totals!();
 crate::impl_client_v17__get_network_info!();
 crate::impl_client_v18__get_node_addresses!();

client/src/client_sync/v20/mod.rs

@@ -74,6 +74,7 @@ crate::impl_client_v17__add_node!();
 crate::impl_client_v17__clear_banned!();
 crate::impl_client_v17__disconnect_node!();
 crate::impl_client_v17__get_added_node_info!();
+crate::impl_client_v17__get_connection_count!();
 crate::impl_client_v17__get_net_totals!();
 crate::impl_client_v17__get_network_info!();
 crate::impl_client_v18__get_node_addresses!();

client/src/client_sync/v21/mod.rs

@@ -76,6 +76,7 @@ crate::impl_client_v17__add_node!();
 crate::impl_client_v17__clear_banned!();
 crate::impl_client_v17__disconnect_node!();
 crate::impl_client_v17__get_added_node_info!();
+crate::impl_client_v17__get_connection_count!();
 crate::impl_client_v17__get_net_totals!();
 crate::impl_client_v17__get_network_info!();
 crate::impl_client_v18__get_node_addresses!();

client/src/client_sync/v22/mod.rs

@@ -76,6 +76,7 @@ crate::impl_client_v17__add_node!();
 crate::impl_client_v17__clear_banned!();
 crate::impl_client_v17__disconnect_node!();
 crate::impl_client_v17__get_added_node_info!();
+crate::impl_client_v17__get_connection_count!();
 crate::impl_client_v17__get_net_totals!();
 crate::impl_client_v17__get_network_info!();
 crate::impl_client_v18__get_node_addresses!();

client/src/client_sync/v23/mod.rs

@@ -78,6 +78,7 @@ crate::impl_client_v17__add_node!();
 crate::impl_client_v17__clear_banned!();
 crate::impl_client_v17__disconnect_node!();
 crate::impl_client_v17__get_added_node_info!();
+crate::impl_client_v17__get_connection_count!();
 crate::impl_client_v17__get_net_totals!();
 crate::impl_client_v17__get_network_info!();
 crate::impl_client_v18__get_node_addresses!();

client/src/client_sync/v24/mod.rs

@@ -75,6 +75,7 @@ crate::impl_client_v17__add_node!();
 crate::impl_client_v17__clear_banned!();
 crate::impl_client_v17__disconnect_node!();
 crate::impl_client_v17__get_added_node_info!();
+crate::impl_client_v17__get_connection_count!();
 crate::impl_client_v17__get_net_totals!();
 crate::impl_client_v17__get_network_info!();
 crate::impl_client_v18__get_node_addresses!();

client/src/client_sync/v25/mod.rs

@@ -75,6 +75,7 @@ crate::impl_client_v17__add_node!();
 crate::impl_client_v17__clear_banned!();
 crate::impl_client_v17__disconnect_node!();
 crate::impl_client_v17__get_added_node_info!();
+crate::impl_client_v17__get_connection_count!();
 crate::impl_client_v17__get_net_totals!();
 crate::impl_client_v17__get_network_info!();
 crate::impl_client_v18__get_node_addresses!();