Skip to content

Commit b764b25

Browse files
author
Le-Roux Enslin
committed
Added male and female titles for the en_ZA locale
- The new titles are for Revenant (Rev.) and Honourable (Hon.) - Remove unused use import for Faker\Provider\DateTime
1 parent 62ee2d8 commit b764b25

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

src/Faker/Provider/en_ZA/Person.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
namespace Faker\Provider\en_ZA;
44

55
use Faker\Calculator\Luhn;
6-
use Faker\Provider\DateTime;
76

87
class Person extends \Faker\Provider\Person
98
{
@@ -127,6 +126,10 @@ class Person extends \Faker\Provider\Person
127126
'Pule', 'Hlophe', 'Miya', 'Moagi',
128127
);
129128

129+
protected static $titleMale = array('Mr.', 'Dr.', 'Prof.', 'Rev.', 'Hon.');
130+
131+
protected static $titleFemale = array('Mrs.', 'Ms.', 'Miss', 'Dr.', 'Prof.', 'Rev.', 'Hon.');
132+
130133
protected static $licenceCodes = array('A', 'A1', 'B', 'C', 'C1', 'C2', 'EB', 'EC', 'EC1', 'I', 'L', 'L1');
131134

132135
/**

test/Faker/Provider/en_ZA/PersonTest.php

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,4 +51,18 @@ public function testLicenceCode()
5151

5252
$this->assertContains($this->faker->licenceCode, $validLicenceCodes);
5353
}
54+
55+
public function testMaleTitles()
56+
{
57+
$validMaleTitles = array('Mr.', 'Dr.', 'Prof.', 'Rev.', 'Hon.');
58+
59+
$this->assertContains(Person::titleMale(), $validMaleTitles);
60+
}
61+
62+
public function testFemaleTitles()
63+
{
64+
$validateFemaleTitles = array('Mrs.', 'Ms.', 'Miss', 'Dr.', 'Prof.', 'Rev.', 'Hon.');
65+
66+
$this->assertContains(Person::titleFemale(), $validateFemaleTitles);
67+
}
5468
}

0 commit comments

Comments
 (0)