Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Adding a key to a Blocto managed wallet renders the wallet unusable #46

Closed
cybercent opened this issue Jan 9, 2023 · 1 comment

Comments

@cybercent
Copy link

cybercent commented Jan 9, 2023


Note:
This is an issue with the Blocto wallet backend on Flow.
I posted this issue here as there is no public repository for Blocto wallet backend.


Reproduce

  1. Go to Flow port and add a new key to your Blocto wallet.
  2. Send any transaction.
  3. The transaction will fail with an invalid signature error.

Issue

It appears that Blocto assumes that:

  • a blocto wallet has only 3 keys and
  • all keys are managed by Blocto

Fix

Instead of using keys.last and assuming the key is managed by Blocto, either

  • use keys[2] (when account was created by Blocto)
  • or check if the key at a specific index is a managed by Blocto before signing
@scottphc
Copy link
Member

Hey, this issue is not releted to this repo and the root cause is from fcl.js onflow/fcl-js#1679. So let's close it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants