Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modelviewer links for temp models based on timestamp #46

Open
bloer opened this issue Feb 18, 2020 · 0 comments
Open

modelviewer links for temp models based on timestamp #46

bloer opened this issue Feb 18, 2020 · 0 comments

Comments

@bloer
Copy link
Owner

bloer commented Feb 18, 2020

modelviewer URLs are of the form "explore/name/version/view". Temporary models fake this structure by using "explore/id/_/view". But internally modelviewer generates relative URLs using the name version syntax. Since the version for temp models is a lastmodified string, those links will be invalid if the temporary model is changed.

Instead modelviewer should check if the viewed model is temporary or not and use id/_ syntax. BUT we need to make sure that this won't cause a database hit every time an URL needs to be build...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant