Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GET id functions in all BE controllers #4463

Open
mcgarrye opened this issue Oct 31, 2024 · 0 comments
Open

Move GET id functions in all BE controllers #4463

mcgarrye opened this issue Oct 31, 2024 · 0 comments
Labels
backend tech debt Historical (deprecated) way to track backend tech debt. Was sort of abandoned

Comments

@mcgarrye
Copy link
Collaborator

After adding a new GET endpoint to the listings path, it was discovered that paths with GET /:id can cause errors if the function is not at the bottom of the file as is recommended by NestJS documentation.
https://docs.nestjs.com/controllers#route-parameters

AC:

  • Update all controllers in the BE to have the GET id functions at the bottom of the file.
  • Update Readme/best practices documentation to include this as a standard
@mcgarrye mcgarrye added the backend tech debt Historical (deprecated) way to track backend tech debt. Was sort of abandoned label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend tech debt Historical (deprecated) way to track backend tech debt. Was sort of abandoned
Projects
None yet
Development

No branches or pull requests

1 participant