Skip to content

Commit 3f3fb53

Browse files
committed
Fix out parameter order in ChannelFactoryPipeline
Signed-off-by: Taylor Foxhall <[email protected]>
1 parent 6fabd1a commit 3f3fb53

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

src/groups/bmq/bmqimp/bmqimp_application.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,13 +142,13 @@ ntcCreateInterfaceConfig(const bmqt::SessionOptions& sessionOptions,
142142
// -------------------------------------------------
143143

144144
Application::ChannelFactoryPipeline::ChannelFactoryPipeline(
145-
const bmqt::SessionOptions& sessionOptions,
146145
bdlbb::BlobBufferFactory* blobBufferFactory,
147146
bdlmt::EventScheduler* scheduler,
147+
BlobSpPool* blobSpPool,
148+
const bmqt::SessionOptions& sessionOptions,
148149
const bmqio::StatChannelFactoryConfig::StatContextCreatorFn&
149150
statContextCreator,
150151
const bmqp_ctrlmsg::NegotiationMessage& negotiationMessage,
151-
BlobSpPool* blobSpPool,
152152
bslma::Allocator* allocator)
153153
: d_allocator_p(bslma::Default::allocator(allocator))
154154
, d_channelFactory(ntcCreateInterfaceConfig(sessionOptions, d_allocator_p),

src/groups/bmq/bmqimp/bmqimp_application.h

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,14 +106,22 @@ class Application {
106106

107107
/// @brief Initialize the channel factory pipeline that this client
108108
/// session will use for creating channels.
109+
///
110+
/// @param blobBufferFactory The factory to allocate blobs for when data is receieved from the network.
111+
/// @param scheduler The scheduler used for retrying connections.
112+
/// @param blobSpPool The object pool used to manage BlobSp's.
113+
/// @param sessionOptions The options used to configure the network sesison
114+
/// @param statContextCreator The factory used to create StatContexts
115+
/// @param negotiationMessage The initial negotiation message to send to the outgoing connection.
116+
/// @param allocator The allocator used to supply memory.
109117
ChannelFactoryPipeline(
110-
const bmqt::SessionOptions& sessionOptions,
111118
bdlbb::BlobBufferFactory* blobBufferFactory,
112119
bdlmt::EventScheduler* scheduler,
120+
BlobSpPool* blobSpPool,
121+
const bmqt::SessionOptions& sessionOptions,
113122
const bmqio::StatChannelFactoryConfig::StatContextCreatorFn&
114123
statContextCreator,
115124
const bmqp_ctrlmsg::NegotiationMessage& negotiationMessage,
116-
BlobSpPool* blobSpPool,
117125
bslma::Allocator* allocator = 0);
118126

119127
// ACCESSORS

0 commit comments

Comments
 (0)