Skip to content

Commit 57d214d

Browse files
committed
Addressing feedback
Signed-off-by: dorjesinpo <[email protected]>
1 parent 64a6c73 commit 57d214d

File tree

8 files changed

+12
-13
lines changed

8 files changed

+12
-13
lines changed

src/groups/mqb/mqbblp/mqbblp_cluster.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -522,7 +522,7 @@ class Cluster : public mqbi::Cluster,
522522
/// will be called soon after this routine is invoked. Invoke the
523523
/// specified `callback` upon completion of (asynchronous) shutdown
524524
/// sequence. Execute shutdown logic where upstream (not downstream) nodes
525-
/// deconfigure queues and the shutting down node waits for CONFIRMS.
525+
/// deconfigure queues and the shutting down node waits for CONFIRMS.
526526
void initiateShutdown(const VoidFunctor& callback) BSLS_KEYWORD_OVERRIDE;
527527

528528
/// Stop the `Cluster`.

src/groups/mqb/mqbblp/mqbblp_clusterproxy.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,8 +184,7 @@ void ClusterProxy::initiateShutdownDispatched(const VoidFunctor& callback)
184184
whenToStop,
185185
bdlf::PlaceHolders::_1)); // completionCb
186186

187-
// Add callback to be invoked once V1 shuts down all client sessions or
188-
// V2 finishes waiting for unconfirmed
187+
// Add callback to be invoked once V2 finishes waiting for unconfirmed
189188
d_shutdownChain.appendInplace(bdlf::BindUtil::bind(&completeShutDown,
190189
bdlf::PlaceHolders::_1),
191190
callback);

src/groups/mqb/mqbblp/mqbblp_clusterproxy.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,7 @@ class ClusterProxy : public mqbc::ClusterStateObserver,
432432
/// `callback` upon completion of (asynchronous) shutdown sequence. It
433433
/// is expected that `stop()` will be called soon after this routine is
434434
/// invoked. Execute shutdown logic where upstream (not downstream) nodes
435-
/// deconfigure queues and the shutting down node waits for CONFIRMS.
435+
/// deconfigure queues and the shutting down node waits for CONFIRMS.
436436
void initiateShutdown(const VoidFunctor& callback) BSLS_KEYWORD_OVERRIDE;
437437

438438
/// Stop the `Cluster`.

src/groups/mqb/mqbblp/mqbblp_queue.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -886,7 +886,7 @@ void Queue::flush()
886886
}
887887
}
888888

889-
bsls::Types::Int64 Queue::countUnconfirmed()
889+
bsls::Types::Int64 Queue::countUnconfirmed() const
890890
{
891891
// executed by the *QUEUE* dispatcher thread
892892

src/groups/mqb/mqbblp/mqbblp_queue.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -260,9 +260,6 @@ class Queue BSLS_CPP11_FINAL : public mqbi::Queue {
260260
void setStats(const bsl::shared_ptr<mqbstat::QueueStatsDomain>& stats)
261261
BSLS_KEYWORD_OVERRIDE;
262262

263-
/// Return number of unconfirmed messages across all handles.
264-
bsls::Types::Int64 countUnconfirmed() BSLS_KEYWORD_OVERRIDE;
265-
266263
/// Stop sending PUSHes but continue receiving CONFIRMs, receiving and
267264
/// sending PUTs and ACKs.
268265
void stopPushing() BSLS_KEYWORD_OVERRIDE;
@@ -414,6 +411,9 @@ class Queue BSLS_CPP11_FINAL : public mqbi::Queue {
414411
const mqbcfg::MessageThrottleConfig&
415412
messageThrottleConfig() const BSLS_KEYWORD_OVERRIDE;
416413

414+
/// Return number of unconfirmed messages across all handles.
415+
bsls::Types::Int64 countUnconfirmed() const BSLS_KEYWORD_OVERRIDE;
416+
417417
// MANIPULATORS
418418
// (mqbi::DispatcherClient)
419419

src/groups/mqb/mqbi/mqbi_queue.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -791,7 +791,7 @@ class Queue : public DispatcherClient {
791791
setStats(const bsl::shared_ptr<mqbstat::QueueStatsDomain>& stats) = 0;
792792

793793
/// Return number of unconfirmed messages across all handles.
794-
virtual bsls::Types::Int64 countUnconfirmed() = 0;
794+
virtual bsls::Types::Int64 countUnconfirmed() const = 0;
795795

796796
/// Stop sending PUSHes but continue receiving CONFIRMs, receiving and
797797
/// sending PUTs and ACKs.

src/groups/mqb/mqbmock/mqbmock_queue.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ Queue::setStats(const bsl::shared_ptr<mqbstat::QueueStatsDomain>& stats)
246246
d_stats_sp = stats;
247247
}
248248

249-
bsls::Types::Int64 Queue::countUnconfirmed()
249+
bsls::Types::Int64 Queue::countUnconfirmed() const
250250
{
251251
// NOT IMPLENTED
252252
return 0;

src/groups/mqb/mqbmock/mqbmock_queue.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -246,9 +246,6 @@ class Queue : public mqbi::Queue {
246246
void setStats(const bsl::shared_ptr<mqbstat::QueueStatsDomain>& stats)
247247
BSLS_KEYWORD_OVERRIDE;
248248

249-
/// Return number of unconfirmed messages across all handles.
250-
bsls::Types::Int64 countUnconfirmed() BSLS_KEYWORD_OVERRIDE;
251-
252249
/// Stop sending PUSHes but continue receiving CONFIRMs, receiving and
253250
/// sending PUTs and ACKs.
254251
void stopPushing() BSLS_KEYWORD_OVERRIDE;
@@ -431,6 +428,9 @@ class Queue : public mqbi::Queue {
431428
/// Return the Schema Leaner associated with this queue.
432429
bmqp::SchemaLearner& schemaLearner() const BSLS_KEYWORD_OVERRIDE;
433430

431+
/// Return number of unconfirmed messages across all handles.
432+
bsls::Types::Int64 countUnconfirmed() const BSLS_KEYWORD_OVERRIDE;
433+
434434
// ACCESSORS
435435
// (specific to mqbi::MockQueue)
436436
};

0 commit comments

Comments
 (0)