Addressing feedback

Signed-off-by: dorjesinpo <[email protected]>

Author: dorjesinpo

src/groups/mqb/mqbblp/mqbblp_cluster.h

@@ -522,7 +522,7 @@ class Cluster : public mqbi::Cluster,
     /// will be called soon after this routine is invoked.  Invoke the
     /// specified `callback` upon completion of (asynchronous) shutdown
     /// sequence.  Execute shutdown logic where upstream (not downstream) nodes
-    /// deconfigure  queues and the shutting down node waits for CONFIRMS.
+    /// deconfigure queues and the shutting down node waits for CONFIRMS.
     void initiateShutdown(const VoidFunctor& callback) BSLS_KEYWORD_OVERRIDE;
 
     /// Stop the `Cluster`.

src/groups/mqb/mqbblp/mqbblp_clusterproxy.cpp

@@ -184,8 +184,7 @@ void ClusterProxy::initiateShutdownDispatched(const VoidFunctor& callback)
                              whenToStop,
                              bdlf::PlaceHolders::_1));  // completionCb
 
-    // Add callback to be invoked once V1 shuts down all client sessions or
-    // V2 finishes waiting for unconfirmed
+    // Add callback to be invoked once V2 finishes waiting for unconfirmed
     d_shutdownChain.appendInplace(bdlf::BindUtil::bind(&completeShutDown,
                                                        bdlf::PlaceHolders::_1),
                                   callback);

src/groups/mqb/mqbblp/mqbblp_clusterproxy.h

@@ -432,7 +432,7 @@ class ClusterProxy : public mqbc::ClusterStateObserver,
     /// `callback` upon completion of (asynchronous) shutdown sequence. It
     /// is expected that `stop()` will be called soon after this routine is
     /// invoked.  Execute shutdown logic where upstream (not downstream) nodes
-    /// deconfigure  queues and the shutting down node waits for CONFIRMS.
+    /// deconfigure queues and the shutting down node waits for CONFIRMS.
     void initiateShutdown(const VoidFunctor& callback) BSLS_KEYWORD_OVERRIDE;
 
     /// Stop the `Cluster`.

src/groups/mqb/mqbblp/mqbblp_queue.cpp

@@ -886,7 +886,7 @@ void Queue::flush()
     }
 }
 
-bsls::Types::Int64 Queue::countUnconfirmed()
+bsls::Types::Int64 Queue::countUnconfirmed() const
 {
     // executed by the *QUEUE* dispatcher thread
 

src/groups/mqb/mqbblp/mqbblp_queue.h

@@ -260,9 +260,6 @@ class Queue BSLS_CPP11_FINAL : public mqbi::Queue {
     void setStats(const bsl::shared_ptr<mqbstat::QueueStatsDomain>& stats)
         BSLS_KEYWORD_OVERRIDE;
 
-    /// Return number of unconfirmed messages across all handles.
-    bsls::Types::Int64 countUnconfirmed() BSLS_KEYWORD_OVERRIDE;
-
     /// Stop sending PUSHes but continue receiving CONFIRMs, receiving and
     /// sending PUTs and ACKs.
     void stopPushing() BSLS_KEYWORD_OVERRIDE;
@@ -414,6 +411,9 @@ class Queue BSLS_CPP11_FINAL : public mqbi::Queue {
     const mqbcfg::MessageThrottleConfig&
     messageThrottleConfig() const BSLS_KEYWORD_OVERRIDE;
 
+    /// Return number of unconfirmed messages across all handles.
+    bsls::Types::Int64 countUnconfirmed() const BSLS_KEYWORD_OVERRIDE;
+
     // MANIPULATORS
     //   (mqbi::DispatcherClient)
 

src/groups/mqb/mqbi/mqbi_queue.h

@@ -791,7 +791,7 @@ class Queue : public DispatcherClient {
     setStats(const bsl::shared_ptr<mqbstat::QueueStatsDomain>& stats) = 0;
 
     /// Return number of unconfirmed messages across all handles.
-    virtual bsls::Types::Int64 countUnconfirmed() = 0;
+    virtual bsls::Types::Int64 countUnconfirmed() const = 0;
 
     /// Stop sending PUSHes but continue receiving CONFIRMs, receiving and
     /// sending PUTs and ACKs.

src/groups/mqb/mqbmock/mqbmock_queue.cpp

@@ -246,7 +246,7 @@ Queue::setStats(const bsl::shared_ptr<mqbstat::QueueStatsDomain>& stats)
     d_stats_sp = stats;
 }
 
-bsls::Types::Int64 Queue::countUnconfirmed()
+bsls::Types::Int64 Queue::countUnconfirmed() const
 {
     // NOT IMPLENTED
     return 0;

src/groups/mqb/mqbmock/mqbmock_queue.h

@@ -246,9 +246,6 @@ class Queue : public mqbi::Queue {
     void setStats(const bsl::shared_ptr<mqbstat::QueueStatsDomain>& stats)
         BSLS_KEYWORD_OVERRIDE;
 
-    /// Return number of unconfirmed messages across all handles.
-    bsls::Types::Int64 countUnconfirmed() BSLS_KEYWORD_OVERRIDE;
-
     /// Stop sending PUSHes but continue receiving CONFIRMs, receiving and
     /// sending PUTs and ACKs.
     void stopPushing() BSLS_KEYWORD_OVERRIDE;
@@ -431,6 +428,9 @@ class Queue : public mqbi::Queue {
     /// Return the Schema Leaner associated with this queue.
     bmqp::SchemaLearner& schemaLearner() const BSLS_KEYWORD_OVERRIDE;
 
+    /// Return number of unconfirmed messages across all handles.
+    bsls::Types::Int64 countUnconfirmed() const BSLS_KEYWORD_OVERRIDE;
+
     // ACCESSORS
     //   (specific to mqbi::MockQueue)
 };