Skip to content

Commit 7142e01

Browse files
committed
Fix[IT]: test_admin_command_routing: skip tests (and report) instead of returning
Signed-off-by: JEAN-LOUIS "JL" LEROY <[email protected]>
1 parent a5f1a88 commit 7142e01

File tree

2 files changed

+7
-12
lines changed

2 files changed

+7
-12
lines changed

.github/workflows/build.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ jobs:
209209
--tb long \
210210
--reruns=3 \
211211
--durations=0 \
212-
-n logical -v
212+
-n logical -v -rs
213213
214214
- name: Print core information
215215
if: failure()

src/integration-tests/test_admin_command_routing.py

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,12 @@
3030
from blazingmq.dev.it.process.client import Client
3131
import json
3232
import multiprocessing.pool
33+
import pytest
34+
35+
pytest.skip(
36+
"Skip admin command routing tests until admin command routing is re-enabled",
37+
allow_module_level=True,
38+
)
3339

3440

3541
def test_primary_rerouting(multi_node: Cluster) -> None:
@@ -49,9 +55,6 @@ def test_primary_rerouting(multi_node: Cluster) -> None:
4955
- CLUSTERS CLUSTER <name> STORAGE PARTITION <partitionId> ENABLE/DISABLE
5056
"""
5157

52-
# TODO Skip admin command routing tests until admin command routing is re-enabled
53-
return
54-
5558
admin = AdminClient()
5659

5760
# find the first node which is not a known leader
@@ -131,9 +134,6 @@ def test_cluster_rerouting(multi_node: Cluster) -> None:
131134
- CLUSTERS CLUSTER <name> STATE ELECTOR GET_ALL <param> <value>
132135
"""
133136

134-
# TODO Skip admin command routing tests until admin command routing is re-enabled
135-
return
136-
137137
admin = AdminClient()
138138

139139
node = multi_node.nodes()[0]
@@ -202,9 +202,6 @@ def test_multi_response_encoding(multi_node: Cluster):
202202
203203
"""
204204

205-
# TODO Skip admin command routing tests until admin command routing is re-enabled
206-
return
207-
208205
def is_compact(json_str: str) -> bool:
209206
return " " not in json_str
210207

@@ -271,8 +268,6 @@ def test_concurrently_routed_commands(multi_node: Cluster, domain_urls: tc.Domai
271268
Stage 2: Issue command in parallel
272269
Stage 3: Expect
273270
"""
274-
# TODO Skip admin command routing tests until admin command routing is re-enabled
275-
return
276271

277272
# Connect a client to each node in the cluster
278273
clients = []

0 commit comments

Comments
 (0)