Skip to content

Commit 7a40386

Browse files
committed
Fix[IT]: also execute tests that do not have a consistency mark
Signed-off-by: JEAN-LOUIS "JL" LEROY <[email protected]>
1 parent bf932c4 commit 7a40386

File tree

2 files changed

+19
-26
lines changed

2 files changed

+19
-26
lines changed

.github/workflows/build.yaml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ jobs:
163163
matrix:
164164
mode: ["legacy_mode", "fsm_mode"]
165165
cluster: ["single", "multi"]
166-
consistency: ["eventual_consistency", "strong_consistency"]
166+
consistency: ["eventual_consistency", "strong_consistency", "not (eventual_consistency or strong_consistency)"]
167167
fail-fast: false
168168
runs-on: ubuntu-latest
169169
needs: build_ubuntu
@@ -198,7 +198,7 @@ jobs:
198198
export GOPATH=$HOME/go
199199
export PATH=$PATH:/usr/local/go/bin:$GOPATH/bin
200200
pip install -r ${{ github.workspace }}/src/python/requirements.txt
201-
${{ github.workspace }}/src/integration-tests/run-tests \
201+
ret=${{ github.workspace }}/src/integration-tests/run-tests \
202202
"${{ matrix.mode }} and ${{ matrix.cluster }} and ${{ matrix.consistency }}" \
203203
--log-level ERROR \
204204
--log-file-level=info \
@@ -209,8 +209,12 @@ jobs:
209209
--tb long \
210210
--reruns=3 \
211211
--durations=0 \
212-
-n logical -v
213-
212+
-n logical -v -rs
213+
if [ "$ret" = 5 ]; then
214+
echo "No tests collected. Exiting with 0."
215+
exit 0
216+
fi
217+
exit "$ret"
214218
- name: Print core information
215219
if: failure()
216220
run: |
@@ -255,7 +259,7 @@ jobs:
255259
deps
256260
/opt/bb/include
257261
key: cache-${{ github.sha }}
258-
262+
259263
- name: Setup core_pattern
260264
run: |
261265
sudo mkdir /cores
@@ -267,7 +271,7 @@ jobs:
267271
pip install -r ${{ github.workspace }}/src/python/requirements.txt
268272
cd src/python
269273
python3 -m blazingmq.dev.fuzztest --broker-dir ${{ github.workspace }}/build/blazingmq/src/applications/bmqbrkr --request ${{ matrix.request }}
270-
274+
271275
- name: Print core information
272276
if: failure()
273277
run: |

src/integration-tests/test_admin_command_routing.py

Lines changed: 9 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,15 @@
3030
from blazingmq.dev.it.process.client import Client
3131
import json
3232
import multiprocessing.pool
33+
import pytest
34+
35+
pytest.skip(
36+
"Skip admin command routing tests until admin command routing is re-enabled",
37+
allow_module_level=True,
38+
)
3339

3440

35-
def test_primary_rerouting(multi_node: Cluster, domain_urls: tc.DomainUrls) -> None:
41+
def test_primary_rerouting(multi_node: Cluster) -> None:
3642
"""
3743
Test: commands intended only for primary node are automatically routed to
3844
primary node and response it sent back when executed from non-primary
@@ -49,11 +55,6 @@ def test_primary_rerouting(multi_node: Cluster, domain_urls: tc.DomainUrls) -> N
4955
- CLUSTERS CLUSTER <name> STORAGE PARTITION <partitionId> ENABLE/DISABLE
5056
"""
5157

52-
# TODO Skip admin command routing tests until admin command routing is re-enabled
53-
return
54-
55-
du = domain_urls
56-
5758
admin = AdminClient()
5859

5960
# find the first node which is not a known leader
@@ -115,7 +116,7 @@ def test_primary_rerouting(multi_node: Cluster, domain_urls: tc.DomainUrls) -> N
115116
admin.stop()
116117

117118

118-
def test_cluster_rerouting(multi_node: Cluster, domain_urls: tc.DomainUrls) -> None:
119+
def test_cluster_rerouting(multi_node: Cluster) -> None:
119120
"""
120121
Test: commands intended for cluster are routed to all nodes in the cluster
121122
regardless of the node the command is initially sent to
@@ -133,11 +134,6 @@ def test_cluster_rerouting(multi_node: Cluster, domain_urls: tc.DomainUrls) -> N
133134
- CLUSTERS CLUSTER <name> STATE ELECTOR GET_ALL <param> <value>
134135
"""
135136

136-
# TODO Skip admin command routing tests until admin command routing is re-enabled
137-
return
138-
139-
du = domain_urls
140-
141137
admin = AdminClient()
142138

143139
node = multi_node.nodes()[0]
@@ -190,7 +186,7 @@ def test_cluster_rerouting(multi_node: Cluster, domain_urls: tc.DomainUrls) -> N
190186
admin.stop()
191187

192188

193-
def test_multi_response_encoding(multi_node: Cluster, domain_urls: tc.DomainUrls):
189+
def test_multi_response_encoding(multi_node: Cluster):
194190
"""
195191
Test: JSON encoding options work with multiple responses (when routing to
196192
multiple nodes)
@@ -206,11 +202,6 @@ def test_multi_response_encoding(multi_node: Cluster, domain_urls: tc.DomainUrls
206202
207203
"""
208204

209-
# TODO Skip admin command routing tests until admin command routing is re-enabled
210-
return
211-
212-
du = domain_urls
213-
214205
def is_compact(json_str: str) -> bool:
215206
return " " not in json_str
216207

@@ -277,8 +268,6 @@ def test_concurrently_routed_commands(multi_node: Cluster, domain_urls: tc.Domai
277268
Stage 2: Issue command in parallel
278269
Stage 3: Expect
279270
"""
280-
# TODO Skip admin command routing tests until admin command routing is re-enabled
281-
return
282271

283272
# Connect a client to each node in the cluster
284273
clients = []

0 commit comments

Comments
 (0)