Skip to content

Commit 7ab4c13

Browse files
authored
Fix[MQB]: revisiting reopening logic (#998)
Signed-off-by: dorjesinpo <[email protected]>
1 parent 019d3d7 commit 7ab4c13

File tree

11 files changed

+734
-647
lines changed

11 files changed

+734
-647
lines changed

src/groups/mqb/mqbblp/mqbblp_cluster.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2640,7 +2640,7 @@ void Cluster::configureQueue(
26402640
callback);
26412641
}
26422642

2643-
void Cluster::configureQueue(
2643+
void Cluster::closeQueue(
26442644
mqbi::Queue* queue,
26452645
const bmqp_ctrlmsg::QueueHandleParameters& handleParameters,
26462646
unsigned int upstreamSubQueueId,
@@ -2651,10 +2651,10 @@ void Cluster::configureQueue(
26512651
// PRECONDITIONS
26522652
BSLS_ASSERT_SAFE(dispatcher()->inDispatcherThread(queue));
26532653

2654-
d_clusterOrchestrator.queueHelper().configureQueue(queue,
2655-
handleParameters,
2656-
upstreamSubQueueId,
2657-
callback);
2654+
d_clusterOrchestrator.queueHelper().closeQueue(queue,
2655+
handleParameters,
2656+
upstreamSubQueueId,
2657+
callback);
26582658
}
26592659

26602660
void Cluster::onQueueHandleCreated(mqbi::Queue* queue,

src/groups/mqb/mqbblp/mqbblp_cluster.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -554,10 +554,10 @@ class Cluster : public mqbi::Cluster,
554554
/// specified `queue` with the specified `handleParameters` and invoke
555555
/// the specified `callback` when finished.
556556
void
557-
configureQueue(mqbi::Queue* queue,
558-
const bmqp_ctrlmsg::QueueHandleParameters& handleParameters,
559-
unsigned int upstreamSubQueueId,
560-
const mqbi::Cluster::HandleReleasedCallback& callback)
557+
closeQueue(mqbi::Queue* queue,
558+
const bmqp_ctrlmsg::QueueHandleParameters& handleParameters,
559+
unsigned int upstreamSubQueueId,
560+
const mqbi::Cluster::HandleReleasedCallback& callback)
561561
BSLS_KEYWORD_OVERRIDE;
562562

563563
/// Invoked whenever an attempt was made to create a queue handle for

src/groups/mqb/mqbblp/mqbblp_clusterproxy.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1153,7 +1153,7 @@ void ClusterProxy::configureQueue(
11531153
callback);
11541154
}
11551155

1156-
void ClusterProxy::configureQueue(
1156+
void ClusterProxy::closeQueue(
11571157
mqbi::Queue* queue,
11581158
const bmqp_ctrlmsg::QueueHandleParameters& handleParameters,
11591159
unsigned int upstreamSubQueueId,
@@ -1164,10 +1164,10 @@ void ClusterProxy::configureQueue(
11641164
// PRECONDITIONS
11651165
BSLS_ASSERT_SAFE(dispatcher()->inDispatcherThread(queue));
11661166

1167-
d_queueHelper.configureQueue(queue,
1168-
handleParameters,
1169-
upstreamSubQueueId,
1170-
callback);
1167+
d_queueHelper.closeQueue(queue,
1168+
handleParameters,
1169+
upstreamSubQueueId,
1170+
callback);
11711171
}
11721172

11731173
void ClusterProxy::onQueueHandleCreated(mqbi::Queue* queue,

src/groups/mqb/mqbblp/mqbblp_clusterproxy.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -469,10 +469,10 @@ class ClusterProxy : public mqbc::ClusterStateObserver,
469469
/// specified `queue` with the specified `handleParameters` and invoke
470470
/// the specified `callback` when finished.
471471
void
472-
configureQueue(mqbi::Queue* queue,
473-
const bmqp_ctrlmsg::QueueHandleParameters& handleParameters,
474-
unsigned int upstreamSubQueueId,
475-
const mqbi::Cluster::HandleReleasedCallback& callback)
472+
closeQueue(mqbi::Queue* queue,
473+
const bmqp_ctrlmsg::QueueHandleParameters& handleParameters,
474+
unsigned int upstreamSubQueueId,
475+
const mqbi::Cluster::HandleReleasedCallback& callback)
476476
BSLS_KEYWORD_OVERRIDE;
477477

478478
/// Invoked whenever an attempt was made to create a queue handle for

0 commit comments

Comments
 (0)