Fix[mqbsl_ledger]: return SUCCESS if ledger is already opened/closed (#954)

Signed-off-by: Evgenii Malygin <[email protected]>

Author: 678098

src/groups/mqb/mqbsi/mqbsi_ledger.cpp

@@ -114,8 +114,6 @@ const char* LedgerOpResult::toAscii(LedgerOpResult::Enum value)
         CASE(SUCCESS)
         CASE(UNKNOWN)
         CASE(LEDGER_NOT_EXIST)
-        CASE(LEDGER_ALREADY_OPENED)
-        CASE(LEDGER_ALREADY_CLOSED)
         CASE(LEDGER_UNGRACEFUL_CLOSE)
         CASE(LEDGER_READ_ONLY)
         CASE(LOG_CREATE_FAILURE)
@@ -151,8 +149,6 @@ bool LedgerOpResult::fromAscii(LedgerOpResult::Enum*    out,
     CHECKVALUE(SUCCESS)
     CHECKVALUE(UNKNOWN)
     CHECKVALUE(LEDGER_NOT_EXIST)
-    CHECKVALUE(LEDGER_ALREADY_OPENED)
-    CHECKVALUE(LEDGER_ALREADY_CLOSED)
     CHECKVALUE(LEDGER_UNGRACEFUL_CLOSE)
     CHECKVALUE(LEDGER_READ_ONLY)
     CHECKVALUE(LOG_CREATE_FAILURE)

src/groups/mqb/mqbsi/mqbsi_ledger.h

@@ -80,9 +80,7 @@ struct LedgerOpResult {
         ,
         e_UNKNOWN                 = -1,
         e_LEDGER_NOT_EXIST        = -2,
-        e_LEDGER_ALREADY_OPENED   = -3,
-        e_LEDGER_ALREADY_CLOSED   = -4,
-        e_LEDGER_UNGRACEFUL_CLOSE = -5
+        e_LEDGER_UNGRACEFUL_CLOSE = -3
 
         // File specific
         // - - - - - - - - - - - - - - - - - - - - - -

src/groups/mqb/mqbsl/mqbsl_ledger.cpp

@@ -424,7 +424,8 @@ Ledger::~Ledger()
 int Ledger::open(int flags)
 {
     if (d_state == LedgerState::e_OPENED) {
-        return LedgerOpResult::e_LEDGER_ALREADY_OPENED;  // RETURN
+        BALL_LOG_WARN << "Ledger is already opened";
+        return LedgerOpResult::e_SUCCESS;  // RETURN
     }
     BSLS_ASSERT_SAFE(d_state == LedgerState::e_CLOSED);
 
@@ -555,7 +556,8 @@ int Ledger::open(int flags)
 int Ledger::close()
 {
     if (d_state == LedgerState::e_CLOSED) {
-        return LedgerOpResult::e_LEDGER_ALREADY_CLOSED;  // RETURN
+        BALL_LOG_WARN << "Ledger is already closed";
+        return LedgerOpResult::e_SUCCESS;  // RETURN
     }
 
     int rc = LedgerOpResult::e_UNKNOWN;