TMP Debugging

Author: kaikulimu

src/groups/mqb/mqbblp/mqbblp_clusterorchestrator.cpp

@@ -1081,8 +1081,8 @@ void ClusterOrchestrator::processNodeStatusAdvisory(
             // may see that heartbeat after the first advisory.
 
             bsl::vector<bmqp_ctrlmsg::PartitionPrimaryInfo> partitions;
-            mqbc::ClusterUtil::loadPartitionsInfo(&partitions,
-                                                  *clusterState());
+            d_stateManager_mp->assignPartitions(
+                &partitions);  // Should be no-op, but doesn't hurt
             d_stateManager_mp->sendClusterState(
                 true,  // sendPartitionPrimaryInfo
                 true,  // sendQueuesInfo
@@ -1194,8 +1194,8 @@ void ClusterOrchestrator::processNodeStateChangeEvent(
                           << node->nodeDescription();
 
             bsl::vector<bmqp_ctrlmsg::PartitionPrimaryInfo> partitions;
-            mqbc::ClusterUtil::loadPartitionsInfo(&partitions,
-                                                  *clusterState());
+            d_stateManager_mp->assignPartitions(
+                &partitions);  // Should be no-op, but doesn't hurt
             d_stateManager_mp->sendClusterState(
                 true,  // sendPartitionPrimaryInfo
                 true,  // sendQueuesInfo
@@ -1807,8 +1807,10 @@ void ClusterOrchestrator::processLeaderPassiveNotification(
     }
 
     // Self is an ACTIVE leader - broadcast 'LeaaderAdvisory'
+    // TODO Can just assign here; you will get same results
     bsl::vector<bmqp_ctrlmsg::PartitionPrimaryInfo> partitions;
-    mqbc::ClusterUtil::loadPartitionsInfo(&partitions, *clusterState());
+    d_stateManager_mp->assignPartitions(
+        &partitions);  // Should be no-op, but doesn't hurt
     d_stateManager_mp->sendClusterState(true,  // sendPartitionPrimaryInfo
                                         true,  // sendQueuesInfo
                                         0,

src/groups/mqb/mqbc/mqbc_clusterutil.cpp

@@ -1440,6 +1440,13 @@ void ClusterUtil::sendClusterState(
 
         advisory.partitions() = partitions;
         loadQueuesInfo(&advisory.queues(), clusterState);
+
+        /** TODO comment */
+        if (!clusterData->clusterConfig()
+                 .clusterAttributes()
+                 .isFSMWorkflow()) {
+            // TODO
+        }
     }
     else if (sendPartitionPrimaryInfo) {
         bmqp_ctrlmsg::PartitionPrimaryAdvisory& advisory =