-
Notifications
You must be signed in to change notification settings - Fork 155
Open
Labels
good first issueGood for newcomersGood for newcomers
Description
Is your feature request related to a problem?
bmqu::AlignedPrinter class has some problems:
- The class' API expects
bsl::vector<const char*>argument which is strange. The conventional way is to passbsl::vector<bsl::string>. - It also stores this vector as a field.
- To get the
const char*length,bsl::strlenis used.
| const bsl::vector<const char*>* fields, |
Describe the solution you'd like
Refactor bmqu::AlignedPrinter, so:
-
bmqu::AlignedPrinterconstructor expectsbsl::string, notconst char* -
bmqu::AlignedPrinteralso stores these strings as aconst bsl::vector<bsl::string>field (might be a pointer, might be a reference) - Add precondition assert that
d_fields_pis not NULL in constructorAlignedPrinter::AlignedPrinteror initialize this field as a reference - Update usage examples in the unit's documentation
- Update the code that uses this class
Alternatives you considered
No response
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers