Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support device ID filtering #32

Open
ES-Alexander opened this issue Jun 24, 2024 · 0 comments
Open

Support device ID filtering #32

ES-Alexander opened this issue Jun 24, 2024 · 0 comments

Comments

@ES-Alexander
Copy link

The message format includes fields for receiver and sender IDs, but using them is documented as "not currently implemented", and they just get hardcoded to 0.

This is a valuable feature for people wanting to communicate with multiple devices on the same bus, as raised in this forum thread.

This seems conceptually straightforward to implement, with a msg.dst_device_id in (0, 255, self.device_id) check in the receiving code, and including the sender ID if there is one set, although full support would require also updating Ping Viewer and the various ping libraries to make use of the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant