Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explanation of why master branch is protected and push force should not happen #6

Open
patrickelectric opened this issue Jul 15, 2021 · 0 comments

Comments

@patrickelectric
Copy link
Member

We did discussed that before and we ended up the current approach, minor changes can appear to be safe, but they may not be or could be done in a better way, so to avoid such problem and be sure that we are not doing something crazy, we agreed to have at least a single approved to any PR, more approves may be necessary if the change is complex or if you desire to have more eyes to be sure that the current approach is correct or may broken something that you are not aware.
We have master branch protected for the majority of our repositories.
PR's are really simple to do, and should not hold your workflow, you can open as much PRs that you feel like, or a single PR with a bunch of fixes. If you are waiting to merge something to add to the documentation before talking with an user, you can ping someone directly and we could approve asap.

I generally avoid committing directly to master, ever. Even a pr as simple as this one could break I forgot we are at Python 3.4 and tried to use f-strings in there.
while there is some extra work to it, these ones are pretty easy to do and quick to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant