nicer log messages & dev relay #997
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev relay default to everything under ./data/ (sqlite and disk persist)
bnewbold
reviewed
Mar 26, 2025
| @@ -24,7 +24,8 @@ type Scheduler struct { | |||
| lk sync.Mutex | |||
| active map[string][]*consumerTask | |||
|
|
|||
| ident string | |||
| identLogKey string | |||
There was a problem hiding this comment.
making this configurable feels pretty convoluted to me. can we just call it "host" or something?
There was a problem hiding this comment.
scheduler was presented as being more generic than that, not explicitly about a "host", but it is actually always used that way, so, ok
There was a problem hiding this comment.
ah, because in relay code I'm trying to move log lines about "host" to be "pds". I think "host" is too generic and if more log lines gather on "pds" it will be easier to search for problem sources in logs. I think some other users of parallel scheduler are using it to process the full relay firehose, so a different log key would make sense there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev relay default to everything under ./data/ (sqlite and disk persist)