Merge pull request #1032 from bluesky/add-missing-asserts

Add missing asserts in tests

Author: ZohebShaikh

CHANGELOG.md

@@ -3,6 +3,12 @@ Write the date in place of the "Unreleased" in the case a new version is release
 
 # Changelog
 
+## v0.1.0-b31 (Unreleased)
+
+### Fixed
+
+- Tests were missing assertions to verify expected outcomes
+
 ## v0.1.0-b30 (2025-07-18)
 
 ## Changed

tiled/_tests/test_access_control.py

@@ -528,7 +528,7 @@ def test_service_principal_access(tmpdir):
         build_app_from_config(config), api_key=key_info["secret"]
     ) as context:
         sp_client = from_context(context)
-        list(sp_client) == ["x"]
+        assert list(sp_client) == ["x"]
 
 
 class CustomAttributesAuthenticator(DictionaryAuthenticator):

tiled/_tests/test_asset_access.py

@@ -35,9 +35,9 @@ def test_include_data_sources_method_on_self(client):
     "Calling include_data_sources() fetches data sources on self."
     x = client.write_array([1, 2, 3], key="x")
     # Fetch data_sources on x object directly.
-    x.data_sources() is not None
+    assert x.data_sources() is not None
     # Fetch data_sources on x object, looked up in client.
-    client["x"].data_sources() is not None
+    assert client["x"].data_sources() is not None
     assert client["x"].include_data_sources().data_sources() is not None
 
 

tiled/_tests/test_caches.py

@@ -16,7 +16,7 @@ def f():
     d = OneShotCachedMap({"a": f})
     # These operations do not cause f to be called.
     len(d)
-    "a" in d
+    assert "a" in d
     list(d)
     assert counter == 0
 
@@ -47,7 +47,7 @@ def f():
 
     # These operations do not cause f to be called.
     len(d)
-    "a" in d
+    assert "a" in d
     list(d)
     assert counter == 0
 

tiled/_tests/test_catalog.py

@@ -98,9 +98,11 @@ async def test_sorting(a):
     assert reversed_default_key_order == list(reversed(default_key_order))
 
     # Sort by key.
-    await a.sort([("id", 1)]).keys_range(0, 10) == ordered_letters
+    assert await a.sort([("id", 1)]).keys_range(0, 10) == ordered_letters
     # Test again, with items_range.
-    [k for k, v in await a.sort([("id", 1)]).items_range(0, 10)] == ordered_letters
+    assert [
+        k for k, v in await a.sort([("id", 1)]).items_range(0, 10)
+    ] == ordered_letters
 
     # Sort by letter metadata.
     # Use explicit 'metadata.{key}' namespace.

tiled/_tests/test_cli.py

@@ -120,5 +120,6 @@ def test_cli_version():
     from tiled import __version__
 
     with run_cli("tiled --version") as process:
+        assert process.stdout is not None
         line = process.stdout.readline()
     assert line.decode() == f"{__version__}{os.linesep}"

tiled/_tests/test_composite.py

@@ -299,4 +299,4 @@ def test_read_selective_with_dim0(context, dim0):
 
     # Check the dimension names
     for var_name in ds.data_vars:
-        ds[var_name].dims[0] == dim0
+        assert ds[var_name].dims[0] == dim0

tiled/_tests/test_custom_format.py

@@ -51,7 +51,7 @@ async def test_xdi_round_trip(tmpdir):
         )
         client["example"].export(str(tmpdir / "exported.xdi"))
         actual = Path(tmpdir / "exported.xdi").read_text()
-        actual
+        assert actual is not None
         # XDI uses a two-space spacing that pandas.to_csv does not support.
         # Need thought to get this exactly right.
         # assert actual == data

tiled/_tests/test_metrics.py

@@ -18,7 +18,7 @@
 
 @router.get("/error")
 def error():
-    1 / 0  # error!
+    1 / 0  # type: ignore error!
 
 
 def total_request_time(client, code):

tiled/_tests/test_queries.py

@@ -246,11 +246,11 @@ def cm():
 
 def test_not_and_and_or(client):
     with pytest.raises(TypeError):
-        not (Key("color") == "red")
+        not (Key("color") == "red")  # type: ignore
     with pytest.raises(TypeError):
-        (Key("color") == "red") and (Key("sample") == "Ni")
+        (Key("color") == "red") and (Key("sample") == "Ni")  # type: ignore
     with pytest.raises(TypeError):
-        (Key("color") == "red") or (Key("sample") == "Ni")
+        (Key("color") == "red") or (Key("sample") == "Ni")  # type: ignore
 
 
 @pytest.mark.parametrize(