Remove top 100 passwords check due to deprecated link (#121) (#122)

Author: harshamurthy

app/assets/javascripts/password.js

@@ -54,27 +54,27 @@ $(document).on('turbolinks:load', function() {
       return password.length >= 10
     }
 
-    window.checkTop100 = function(password) {
-      if (!window.top100) {
-        getTop100().then(function() {
-          return !window.top100.includes(password)
-        })
-      } else {
-        return !window.top100.includes(password)
-      }
-
-    }
-
-    function getTop100() {
-      return $.ajax({
-        url: 'https://raw.githubusercontent.com/danielmiessler/SecLists/master/Passwords/10_million_password_list_top_100.txt'
-      }).then(function(data) {
-        window.top100 = data
-      })
-    }
-
     window.ensureDoesntMatchEmail = function(password) {
       return $('#registration_email').val() != password
     }
+
+    // window.checkTop100 = function(password) {
+    //   if (!window.top100) {
+    //     getTop100().then(function() {
+    //       return !window.top100.includes(password)
+    //     })
+    //   } else {
+    //     return !window.top100.includes(password)
+    //   }
+    //
+    // }
+
+    // function getTop100() {
+    //   return $.ajax({
+    //     url: 'https://raw.githubusercontent.com/danielmiessler/SecLists/master/Passwords/10_million_password_list_top_100.txt'
+    //   }).then(function(data) {
+    //     window.top100 = data
+    //   })
+    // }
   }
 })

app/views/passwords/edit.html.erb

@@ -14,7 +14,7 @@
           </ol>
         </div>
         <div id="showHidePassword">
-          <%= password_field_tag :password, nil, id: "reset_password", data: { rules: "checkLength,checkTop100" } %>
+          <%= password_field_tag :password, nil, id: "reset_password", data: { rules: "checkLength" } %>
         </div>
       </div>
 

app/views/users/new.html.erb

@@ -39,12 +39,12 @@
           <p>We know password rules are annoying, but there are some easy ways to ensure your account remains secure. For more info on why we use these password constraints, check out <%= link_to 'Password Rules Are Bullshit', 'https://blog.codinghorror.com/password-rules-are-bullshit/', target: '_blank' %> on the Coding Horror blog.</p>
           <ol>
             <li>Minimum length of 10 characters <span class="xMark"></span></li>
-            <li>Isn't in the <%= link_to 'top 100', 'https://raw.githubusercontent.com/danielmiessler/SecLists/master/Passwords/10_million_password_list_top_100.txt'%> most common passwords <span class="xMark"></span></li>
+            <!-- <li>Isn't in the <%#= link_to 'top 100', 'https://raw.githubusercontent.com/danielmiessler/SecLists/master/Passwords/10_million_password_list_top_100.txt'%> most common passwords <span class="xMark"></span></li> -->
             <li>Doesn't match your email <span class="xMark"></span></li>
           </ol>
         </div>
         <div id="showHidePassword">
-          <%= f.password_field :password, data: { rules: "checkLength,checkTop100,ensureDoesntMatchEmail" } %>
+          <%= f.password_field :password, data: { rules: "checkLength,ensureDoesntMatchEmail" } %>
         </div>
       </div>