[nedap#126] Remove mount/args support

- While potentially handy in some cases, most often the dual (and
  independent) configuration's for mount can get confusing.

Author: barracudarin

src/formatting_stack/mount.clj

@@ -12,15 +12,5 @@
        (apply format!))
   this)
 
-;; Allow parameterless configuring using `mount/start-with-args`.
-(mount-up/on-up :formatting-with-mount-args
-                (fn [_]
-                  (when-let [config (::config (mount/args))]
-                    (start config)))
-                :before)
-
-(defn configure [config]
-  (mount-up/on-up :formatting-with-provided-config
-                  (fn [_]
-                    (start config))
-                  :before))
+(defn configure! [config]
+  (mount-up/on-up :formatting (fn [_] (start config)) :before))

test/functional/formatting_stack/mount.clj

@@ -35,26 +35,9 @@
                 :processors               []
                 :in-background?           false
                 :reporter                 (reporters.passthrough/new)}]
-      (sut/configure opts)
+      (sut/configure! opts)
       (mount/start)
       (testing "It actually runs its members, such as linters"
         (is (= [sample-report]
                @p)))
       (mount/stop))))
-
-(deftest works-with-mount-args
-  (testing "It can be started/stopped without errors"
-    (let [p (atom nil)
-          ;; pass an empty stack (except for the `proof`), so that no side-effects will be triggered (would muddy the test suite):
-          opts {:strategies               []
-                :third-party-indent-specs {}
-                :formatters               []
-                :linters                  [(proof p)]
-                :processors               []
-                :in-background?           false
-                :reporter                 (reporters.passthrough/new)}]
-      (mount/start-with-args {:formatting-stack.mount/config opts})
-      (testing "It actually runs its members, such as linters"
-        (is (= [sample-report]
-               @p)))
-      (mount/stop))))