Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang-cl flags -Wmicrosoft-unqualified-friend warnings #19

Open
rubenvb opened this issue Nov 22, 2019 · 0 comments
Open

Clang-cl flags -Wmicrosoft-unqualified-friend warnings #19

rubenvb opened this issue Nov 22, 2019 · 0 comments

Comments

@rubenvb
Copy link

rubenvb commented Nov 22, 2019

In Boost 1.70 (and current master, but I don't have the line numbers handy), these lines spawn a warning:

unqualified friend declaration referring to type outside of the nearest enclosing namespace is a Microsoft extension; add a nested name specifier
map_view_iterator.hpp:
87, 138, 174, 215, 252, 293, 329

It seems to me that simply adding a ::boost::iterators:: qualification will fix this issue. See e.g. https://kod.acikkaynak.gov.tr/libreoffice/core/commit/aef6da021da33f099f99ed633814b8771ad4abda which seems to "fix" the warning locally by disabling the warning.

You can try Clang-cl by installing the CLang-cl options in the VS2019 installer, and e.g. running CMake with -T"ClangCL", or specifying the compiler manually using -DCMAKE_CXX_COMPILER=path/to/clang-cl.exe. You can also just use LLVM's version of clang-cl, it seems to be identical. Just make sure you have either VS2017 or VS2019 installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant