Skip to content

Commit e96d544

Browse files
henrywangcgwalters
authored andcommitted
ci: Build test binaries before sudo commands
Move `cargo build --release -p tests-integration` to run before `sudo podman build` to avoid cargo registry permission issues. The tests-integration binary doesn't depend on the fsverity image, so this reordering has no functional impact on the test flow. Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
1 parent 14613a0 commit e96d544

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,11 +73,12 @@ jobs:
7373
just copy-to-rootful localhost/bootc-install
7474
# Copy bound images (LBI) to root's storage for tests that need them
7575
just copy-lbi-to-rootful
76-
sudo podman build -t localhost/bootc-fsverity -f ci/Containerfile.install-fsverity
7776
78-
# TODO move into a container, and then have this tool run other containers
77+
# Build test binaries before any sudo commands to avoid cargo permission issues
7978
cargo build --release -p tests-integration
8079
80+
sudo podman build -t localhost/bootc-fsverity -f ci/Containerfile.install-fsverity
81+
8182
df -h /
8283
sudo install -m 0755 target/release/tests-integration /usr/bin/bootc-integration-tests
8384
sudo rm target -rf

0 commit comments

Comments
 (0)