-
Notifications
You must be signed in to change notification settings - Fork 864
Description
I have the edits to fix the following on on a branch. I do not have the write permissions to push them.
These are likely the result of strict compiler settings, so non-critical.
Description
After cloning the repository, I am running make check. It reports the following errors.
at 54% it gives the error: fixed by removing the semicolon
[ 54%] Built target testAlgebraicDecisionTree
[ 54%] Building CXX object gtsam/discrete/tests/CMakeFiles/testDecisionTree.dir/testDecisionTree.cpp.o
/home/farrell/Documents/GTSam/gtsam/discrete/tests/testDecisionTree.cpp:322:50: error: extra ‘;’ [-Werror=pedantic]
322 | bool bool_of_int(const int& y) { return y != 0; };
| ^
cc1plus: all warnings being treated as errors
make[3]: *** [gtsam/discrete/tests/CMakeFiles/testDecisionTree.dir/build.make:76: gtsam/discrete/tests/CMakeFiles/testDecisionTree.dir/testDecisionTree.cpp.o] Error 1
make[2]: *** [CMakeFiles/Makefile2:10682: gtsam/discrete/tests/CMakeFiles/testDecisionTree.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:2622: CMakeFiles/check.dir/rule] Error 2
make: *** [Makefile:199: check] Error 2
at 57% it gives the error: fixed by removing the semicolons
[ 57%] Built target testDiscreteValues
[ 57%] Building CXX object gtsam/discrete/tests/CMakeFiles/testSerializationDiscrete.dir/testSerializationDiscrete.cpp.o
/home/farrell/Documents/GTSam/gtsam/discrete/tests/testSerializationDiscrete.cpp:35:72: error: extra ‘;’ [-Werror=pedantic]
35 | BOOST_CLASS_EXPORT_GUID(DecisionTreeFactor, "gtsam_DecisionTreeFactor");
| ^
/home/farrell/Documents/GTSam/gtsam/discrete/tests/testSerializationDiscrete.cpp:36:58: error: extra ‘;’ [-Werror=pedantic]
36 | BOOST_CLASS_EXPORT_GUID(TableFactor, "gtsam_TableFactor");
| ^
/home/farrell/Documents/GTSam/gtsam/discrete/tests/testSerializationDiscrete.cpp:39:60: error: extra ‘;’ [-Werror=pedantic]
39 | BOOST_CLASS_EXPORT_GUID(ADT, "gtsam_AlgebraicDecisionTree");
| ^
cc1plus: all warnings being treated as errors
make[3]: *** [gtsam/discrete/tests/CMakeFiles/testSerializationDiscrete.dir/build.make:76: gtsam/discrete/tests/CMakeFiles/testSerializationDiscrete.dir/testSerializationDiscrete.cpp.o] Error 1
make[2]: *** [CMakeFiles/Makefile2:11654: gtsam/discrete/tests/CMakeFiles/testSerializationDiscrete.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:2622: CMakeFiles/check.dir/rule] Error 2
make: *** [Makefile:199: check] Error 2
at 58% it gives the error: fixed by removing the semicolons
[ 58%] Built target testDCSAM
[ 58%] Building CXX object gtsam/hybrid/tests/CMakeFiles/testGaussianMixture.dir/testGaussianMixture.cpp.o
/home/farrell/Documents/GTSam/gtsam/hybrid/tests/testGaussianMixture.cpp:50:2: error: extra ‘;’ [-Werror=pedantic]
50 | };
| ^
/home/farrell/Documents/GTSam/gtsam/hybrid/tests/testGaussianMixture.cpp:62:2: error: extra ‘;’ [-Werror=pedantic]
62 | };
| ^
cc1plus: all warnings being treated as errors
make[3]: *** [gtsam/hybrid/tests/CMakeFiles/testGaussianMixture.dir/build.make:76: gtsam/hybrid/tests/CMakeFiles/testGaussianMixture.dir/testGaussianMixture.cpp.o] Error 1
make[2]: *** [CMakeFiles/Makefile2:12103: gtsam/hybrid/tests/CMakeFiles/testGaussianMixture.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:2622: CMakeFiles/check.dir/rule] Error 2
make: *** [Makefile:199: check] Error 2
at 62%, similar errors. To many to paste.
cc1plus: all warnings being treated as errors
make[3]: *** [gtsam/hybrid/tests/CMakeFiles/testSerializationHybrid.dir/build.make:76: gtsam/hybrid/tests/CMakeFiles/testSerializationHybrid.dir/testSerializationHybrid.cpp.o] Error 1
make[2]: *** [CMakeFiles/Makefile2:13480: gtsam/hybrid/tests/CMakeFiles/testSerializationHybrid.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:2622: CMakeFiles/check.dir/rule] Error 2
make: *** [Makefile:199: check] Error 2
various other similar
These are likely due to the strict compiler settings. Since I have them fixed, I would submit a PR, but I do not have write permission for the repo.