-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python-install fails because of stubgen: #167
Comments
Actually, even after disabling the stub generation, the library installs fine but the same
Did something about this change in the last PRs? It's weird as it still works in CI. I remember that this circular thing was an issue a long time ago, but it's weird it pops up again now. |
Seems the .so file was built for 3.12, but I made sure all cmake versions where 3.10... Does this ring a possible bell, @varunagrawal ? |
Check the GTSAM_PYTHON_VERSION and Cmake variables for the Python version in general. This looks like it is being set to different things in different variables. This issue has bitten me before as well but it's a simple manual change hence I never tried to fix it. |
They are all 3.10 |
And, I did:
And it installs in right directory. But somehow something is generating 3.12 binaries? |
It works in a conda 3.12 environment (again with custom cmake) |
@dellaert I assume you nuked the entire build folder right? Could you paste your |
Did you give it a try on Ubuntu with 3.10? PS Should CI not test all python versions we support? It should also test that cmake works out of the box in a conda or virtualenv… |
I could do a quick test with a devcontainer… |
I can test with a Docker in a sec |
I am in a python3 conda environment, on MacOS 14.6.1,
(py310) (base) macbook-pro-8:build dellaert$ python --version
Python 3.10.14
The text was updated successfully, but these errors were encountered: