Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle linter issues #7

Open
dynobo opened this issue Jul 5, 2021 · 1 comment
Open

Handle linter issues #7

dynobo opened this issue Jul 5, 2021 · 1 comment
Assignees
@dynobo

Comments

@dynobo
Copy link
Collaborator

dynobo commented Jul 5, 2021

After #4 (and #5) are merged, we should run pylint and mypy and handle the issues that are found.
@dynobo dynobo self-assigned this Jul 6, 2021
dynobo added a commit that referenced this issue Jul 6, 2021
@dynobo
Use tuples as init args according to hints. #7
7df59d3 
Signed-off-by: Buech Holger <[email protected]>
dynobo added a commit that referenced this issue Jul 6, 2021
@dynobo
Fix obvious numpy related type hints. #7
0f5232b 
Signed-off-by: Buech Holger <[email protected]>
dynobo added a commit that referenced this issue Jul 6, 2021
@dynobo
Fix unsupported target for indexed assignement. #7
9ebd434 
Signed-off-by: Buech Holger <[email protected]>
dynobo added a commit that referenced this issue Jul 6, 2021
@dynobo
Fix EOLs. #7
f684867 
Signed-off-by: Buech Holger <[email protected]>
dynobo added a commit that referenced this issue Jul 6, 2021
@dynobo
Fix line length for comments and strings. #7
7afc6e0 
Signed-off-by: Buech Holger <[email protected]>
dynobo added a commit that referenced this issue Jul 6, 2021
@dynobo
Fix easy to solve pylint issues. #7
846fe48 
Signed-off-by: Buech Holger <[email protected]>
@dynobo
Copy link
Collaborator Author

dynobo commented Jul 12, 2021

Easy fixes are done with #14, for the remaining ones we need some time and discussion.

@dynobo dynobo mentioned this issue Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dynobo dynobo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dynobo