Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in cfnsignal only for AWS k8s and ecs variants #71

Open
arnaldo2792 opened this issue Aug 8, 2024 · 0 comments
Open

Pull in cfnsignal only for AWS k8s and ecs variants #71

arnaldo2792 opened this issue Aug 8, 2024 · 0 comments

Comments

@arnaldo2792
Copy link
Contributor

What I'd like:
By default, all downstream builders whose image matches aws-* will get cfsignal installed. This isn't ideal because those downstream builders might not include in their variant the APIs required by this feature, which will cause the system to be in a degraded state. We have to narrow down when cfsignal is required by only installing it for the aws-k8s and aws-ecs families. If downstreams require this feature, they can explicitly require it in their variant definition.

Any alternatives you've considered:
Keep cfsignal and the system in a degraded state for downstream builders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant