Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset interpolation efficiency #164

Open
johnomotani opened this issue Oct 23, 2020 · 0 comments
Open

Dataset interpolation efficiency #164

johnomotani opened this issue Oct 23, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@johnomotani
Copy link
Collaborator

At the moment interpolate_parallel is implemented for BoutDataArray, and BoutDataset.interpolate_parallel() iterates over the member variables. This means that the coordinates get interpolated many times. It would probably be more efficient to implement either as a utility function that can be called on either a DataArray or a Dataset and then is called in BoutDataArray.interpolate_parallel() and BoutDataset.interpolate_parallel() on self, or to implement for BoutDataset (which should be mostly a copy-paste of the BoutDataArray.interpolate_parallel() code, and then in BoutDataArray.interpolate_parallel() convert the DataArray to a Dataset with one member variable, call the BoutDataset method, and convert back to a DataArray.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant