Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging 'coordinates' can be slow, could be skipped? (performance) #220

Open
johnomotani opened this issue Oct 4, 2021 · 1 comment
Open

Comments

@johnomotani
Copy link
Collaborator

In some routines, for example BoutDataset.interpolate_parallel(), many variables have to be merged back together. If they have coordinates, then these are checked for consistency. If coordinates are removed from the variable(s) being merged, then the merge can be much quicker. In some cases (e.g. looking at a slice with only one time point) this merging seems to take longer than the actual parallel interpolation. It might be worth (to improve performance) removing coordinates before merging, or using one of the xarray options ("override" somewhere?) to skip the comparisons - possibly controlled by a global option?

@johnomotani
Copy link
Collaborator Author

Would be interesting to see if this is improved by the latest xarray release - pydata/xarray#7824 may help things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant