Redundent transmute in osmflat_generated

[hallahan]

Often times there are accessors that transmute the same time into itself such as:

osmflat-rs/osmflat/src/osmflat_generated.rs

Lines 494 to 497 in 011d70a

	pub fn id(&self) -> i64 {
	let value = flatdata_read_bytes!(i64, self.data.as_ptr(), 0, 40);
	unsafe { std::mem::transmute::<i64, i64>(value) }
	}

Is there any reason why this is being done, or is it something odd with the code generator? In this instance, the id is already an i64. Why transmute?

[VeaaC]

This is due to the generator supporting to deserialize enumerations: Those need to be transmuted. The generator could theoretically skip the useless transmute by checking if target type matches source type, but the way it was implemented right now it just always transmutes, even if it is a no-op.

[hallahan]

I wonder if there is any performance hit?

[VeaaC]

Only in debug mode, release mode optimizes everything away. Similarly the flatdata_read_bytes macro is fully optimized to generate code similar to C++ bitfields.