Setting recovery message with nvram exec will fail if it contains an apostrophe

[glarizza]

Note this line in the exec --> https://github.com/boxen/puppet-osx/blob/master/manifests/recovery_message.pp#L46

Because the value is wrapped in single-quotes, if you declare an osx::recovery_message resource that contains a single-quote/apostrophe in its title, the exec will fail. Removing the apostrophe fixes the exec failure.

I'm not sure of the solution here - maybe wrapping in double-quotes instead of single quotes (which displaces the issue to double-quotes), or possibly a function that searches for apostrophes and escapes them?

[ocxo]

I'd probably just manually escape quotes in osx::recovery_message and be done with it. What do you think about adding a note to the readme about this?

[bleything]

Elsewhere @wfarr mentioned a shell quoting function we could use. Assuming I'm remembering that correctly, that's the right solution.

[ocxo]

Nice. I don't think it warrants additional code IMO but if there is something we can tap into let's do it.

On Jun 27, 2013, at 10:27 AM, Ben Bleything notifications@github.com wrote:

Elsewhere @wfarr mentioned a shell quoting function we could use. Assuming I'm remembering that correctly, that's the right solution.

—
Reply to this email directly or view it on GitHub.

[glarizza]

There is the shellquote function, but I don't think it solves this problem. I filed #23 which should cover us for now.

[wfarr]

I think if we're gonna re-do this, I'd like to see us approach solving the problem permanently.

Right now, we're relying on RubyCocoa and all sorts of stuff to set the recovery message. Stuff that's also going away in 10.9.

It's time to write some C.

Though, yes, shell quote is useful here.