The undo stack inserts deleted content in the wrong flow nodes

[christian-konrad]

Describe the Bug

When you delete a name or id of a flow node in the properties panel, then add a new node and hit undo, the name or id is inserted back again - in the right property, but of the wrong flow node. So, the revert operation is not conducted properly. Also, adding the flow node itself is not reverted. It seems like the undo stacks of the properties panel and bpmn-js clash.

Steps to Reproduce

1. Have a flow node
2. Enter a name or id
3. Remove the name or id (select all + entf/backspace/cut)
4. Add a new flow node
5. Hit undo
6. -> The name or id is inserted back again, but in the currently selected flow node (the new one)

Or just see the videos.

Bildschirmaufnahme.2022-06-28.um.22.01.23.mov

Bildschirmaufnahme.2022-06-28.um.21.59.22.mov

(Not validated if this also applies to other properties than ids and names).

Expected Behavior

Hitting undo, at first the newly added flow node should be removed, then the name or id should be inserted back again in the original node.

Environment

• Desktop Modeler 5.0.0 and Web Modeler (Nightly and our current dev env ultrawombat)

[pinussilvestrus]

Seems like this is related to direct editing visible after creating/appending tasks and text annotations.

I can't reproduce it if I append a flow node that's not immediately activating direct editing.

[pinussilvestrus]

I looked through the commit history to find a point where it is working properly. The bug even occurs in version 1.0.0-alpha.0.

I was not able to find the root cause for this in a time-boxed manner. However, I created a test case via 0dcd373 that tries to reproduce the issue.

Branch: 712-wrong-command-removal

What I found while creating the test case:

• The test case is failing randomly because the name input sometimes has focus. It shouldn't be like that after append, as direct editing is activated. Sometimes it just works as expected.
• When doing the same by firing command via commandStack only, everything works as expected.

This could be an indication that something is going on with handling the keyboard bindings + focusing properly between the modeler and properties panel.

I'd need more time to investigate this, so I'd propose to move this to the backlog as it's not a blocker.

/cc @christian-konrad @CatalinaMoisuc

[marstamm]

Expected Behavior

Hitting undo, at first the newly added flow node should be removed, then the name or id should be inserted back again in the original node.

As we are in the context of direct editing, undo should not be handled by bpmn-js at all but perform the native undo/redo on the contenteditable div