Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add i18n configuration #131

Open
iorizqz opened this issue Feb 20, 2023 · 5 comments
Open

Add i18n configuration #131

iorizqz opened this issue Feb 20, 2023 · 5 comments
Labels
backlog Queued in backlog enhancement New feature or request pr welcome We rely on a community contribution to improve this.

Comments

@iorizqz
Copy link

iorizqz commented Feb 20, 2023 •
edited by nikku
Loading

What shall we do?

Add i18n configuration

How shall we do it?

Use the translate / i18n infrastructure provided by diagram-js, cf. bpmn-js-i18n example. Essentially that means wrapping all string usages in a translate('the string') call.
@iorizqz iorizqz added the enhancement New feature or request label Feb 20, 2023
@nikku
Copy link
Member

nikku commented Feb 20, 2023 •
edited
Loading

I guess you want this library to be internationalized, i.e. by using the diagram-js translate call?

Happy to take a contribute that adds this. Updated the issue with further information.

@nikku nikku added pr welcome We rely on a community contribution to improve this. backlog Queued in backlog labels Feb 20, 2023
@iorizqz
Copy link
Author

iorizqz commented Feb 21, 2023 •
edited
Loading

That's what it means！ the english lang is default locale. translate called param is english('the string')!
Sorting 'the string' is a lot of work

image

image

@nikku
Copy link
Member

nikku commented Feb 21, 2023

@iorizqz Do you want to contribute that change?

@iorizqz
Copy link
Author

iorizqz commented Feb 22, 2023 •
edited
Loading

I enjoy! According to the contributing guidelines, should I create a pull request?
I fork the master branch?

@nikku
Copy link
Member

nikku commented Feb 22, 2023

You'd want to fork this repository, do the necessary changes and submit a pull request, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog Queued in backlog enhancement New feature or request pr welcome We rely on a community contribution to improve this.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikku @iorizqz