feat(popup-menu): prioritize search over description when matching entries

Author: nikku

lib/features/popup-menu/PopupMenuComponent.js

@@ -88,8 +88,8 @@ export default function PopupMenuComponent(props) {
     return searchFn(searchableEntries, searchValue, {
       keys: [
         'label',
-        'description',
-        'search'
+        'search',
+        'description'
       ]
     }).map(({ item }) => item);
   }, [ searchable ]);

test/spec/features/popup-menu/PopupMenuSpec.js

@@ -1495,6 +1495,51 @@ describe('features/popup-menu', function() {
     }));
 
 
+    it('should show search results (prioritizing search over description)', inject(async function(popupMenu) {
+
+      // given
+      popupMenu.registerProvider('test-menu', {
+        getEntries: function() {
+          return [
+            {
+              id: 'search',
+              label: 'First',
+              search: 'search'
+            },
+            {
+              id: 'description',
+              label: 'Second',
+              description: 'search things'
+            },
+            {
+              id: 'other-1',
+              label: 'Other 1'
+            },
+            {
+              id: 'other-2',
+              label: 'Other 2'
+            },
+            {
+              id: 'other-3',
+              label: 'Other 3'
+            },
+            {
+              id: 'other-4',
+              label: 'Other 4'
+            }
+          ];
+        }
+      });
+      popupMenu.open({}, 'test-menu', { x: 100, y: 100 }, { search: true });
+
+      // when
+      await triggerSearch('search');
+
+      // then
+      await expectEntries([ 'First', 'Second' ]);
+    }));
+
+
     it('should show search results (matching label & search)', inject(async function(popupMenu) {
 
       // given