Skip to content

The isEdited flags are not consistently applied here compared to bpmn and dmn #1407

@Skaiir

Description

@Skaiir

Describe the Bug

The isEdited flags, ie the dots that appear in the properties panel, are not consistently applied in forms.

Following a pretty large discussion, we outlined that form-js doesn't follow the established pattern when it comes to displaying the edit dots.

The semantic should be: a value in this group has been changed from its default, with the only exception being defaults that are generated like IDs as there are no good ways of determining this status at the moment, so we always have them as edited (I'm trying to raise some discussions around this).

List of the inconsistencies

Tackled immediately via #1409
  • Options source group
  • Text view general (no generated data, should be unedited by default)
  • Table headers source
  • Time constraints 15m default
  • Time serialization format default
  • Group + dynamic list show outline should be inverted
Need some more thinking
  • Document preview general -> Impossible to get no defaults, so do we really care?
  • Spacer general -> Kind of annoying to implement due to the component inheritance with iframes of heights
  • Button general ->Not all that useful to fix
  • Group + dynamic list appearance vertical alignment has no default when usually we set a default option, might be a different issue altogether but related
  • IFrame general -> No default height, do we care here?

Steps to Reproduce

  1. Add a select component
  2. General group shows as edited -> expected as it contains a generated ID
  3. Options source group shows as edited -> not expected, this is a default and shouldn't show the dot

Expected Behavior

  1. Options source should not show as edited. Many other scenarios with the same problem.

Environment

All

Metadata

Metadata

Assignees

No one assigned

    Labels

    backlogQueued in backlogbugSomething isn't workingneeds discussionNeeds further discussion

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions