Skip to content

[Desktop] Fix deps in //brave/browser/ui/bookmark #10654

@jumde

Description

@jumde
$gn check . //brave/browser/ui/bookmark/*

ERROR at //brave/browser/ui/bookmark/brave_bookmark_tab_helper.h:9:11: Include not allowed.
#include "chrome/browser/ui/bookmarks/bookmark_tab_helper.h"
          ^------------------------------------------------
It is not in any dependency of
  //brave/browser/ui/bookmark:bookmark
The include file is in the target(s):
  //chrome/browser/ui:ui
which should somehow be reachable.
___________________
ERROR at //brave/browser/ui/bookmark/bookmark_prefs_service_factory.cc:9:11: Can't include this header from here.
#include "brave/common/pref_names.h"
          ^------------------------
The target:
  //brave/browser/ui/bookmark:bookmark
is including a file from the target:
  //brave/common:pref_names

It's usually best to depend directly on the destination target.
In some cases, the destination target is considered a subcomponent
of an intermediate target. In this case, the intermediate target

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions