-
Notifications
You must be signed in to change notification settings - Fork 1k
Remove stats usage ping disabled by policy pref, rename policy #30514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: origin-pref-cleanup1
Are you sure you want to change the base?
Conversation
Warning You have got a presubmit warning. Please address it if possible.
|
Warning You have got a presubmit warning. Please address it if possible.
Items:
|
void BravePrivacyHandler::OnStatsUsagePingEnabledChanged() { | ||
if (IsJavascriptAllowed()) { | ||
PrefService* local_state = g_browser_process->local_state(); | ||
bool user_enabled = local_state->GetBoolean(kStatsReportingEnabled); | ||
bool policy_disabled = | ||
local_state->GetBoolean(kStatsReportingDisabledByPolicy); | ||
bool hidden = IsStatsReportingHidden(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, after some discussion with @bbondy I think I understand what we're doing here now. I thought we were using brave origin to set the managed pref value, but the two things are independent so ideally we really would have split them into two PRs. Still working through some details to figure out what makes the most sense here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
9d83e51
to
3565f94
Compare
3565f94
to
4044766
Compare
Warning You have got a presubmit warning. Please address it if possible.
Items:
|
A Storybook has been deployed to preview UI for the latest push |
brave/brave-browser#48187