Skip to content

Remove P3A disabled by policy pref, rename policy #30515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: origin-pref-cleanup2
Choose a base branch
from
Open

Remove P3A disabled by policy pref, rename policy #30515

wants to merge 2 commits into from
+27 −46

Conversation

DJAndries
Copy link
Collaborator

@DJAndries DJAndries commented Aug 7, 2025 •
edited
Loading

@DJAndries DJAndries requested review from bbondy and bsclifton August 7, 2025 00:53
@DJAndries DJAndries requested review from a team and bridiver as code owners August 7, 2025 00:53
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Aug 7, 2025
@DJAndries DJAndries changed the title Remove P3A disabled by policy pref Remove P3A disabled by policy pref, rename policy Aug 7, 2025
@brave-builds
Copy link
Collaborator

Warning

You have got a presubmit warning. Please address it if possible.

Discovered possible removal of preference registrations.

Please make sure to properly deprecate preferences by clearing their
value for a couple of milestones before finally removing the code.
Otherwise data may stay in the preferences files forever. See
Migrate*Prefs() in chrome/browser/prefs/browser_prefs.cc and
chrome/browser/prefs/README.md for examples.
This may be a false positive warning (e.g. if you move preference
registrations to a different place).

Items:

components/p3a/p3a_service.cc: -  registry->RegisterBooleanPref(kP3ADisabledByPolicy, false);

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@bsclifton bsclifton mentioned this pull request Aug 7, 2025
Open
7 tasks
bsclifton
bsclifton approved these changes Aug 7, 2025
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@DJAndries DJAndries force-pushed the origin-pref-cleanup2 branch from 9d83e51 to 3565f94 Compare August 7, 2025 21:13
@DJAndries DJAndries requested a review from simonhong as a code owner August 7, 2025 21:13
@DJAndries DJAndries force-pushed the origin-pref-cleanup2 branch from 3565f94 to 4044766 Compare August 7, 2025 22:31
@DJAndries DJAndries force-pushed the origin-pref-cleanup3 branch from 868fa0b to 6fe2a49 Compare August 7, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

@simonhong simonhong Awaiting requested review from simonhong

Assignees

@DJAndries DJAndries

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DJAndries @brave-builds @bsclifton