[Brave Midnight] Add Brave Midnight (Darker) theme feature and pref #30520
+343
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CI/storybook-url
sangwoo108
force-pushed
the
sko/midnight
branch
from
8a7be7b to
b274526
Compare
|
Warning You have got a presubmit warning. Please address it if possible. Items: |
sangwoo108
force-pushed
the
sko/midnight
branch
2 times, most recently
from
18bee19 to
4ea19ce
Compare
sangwoo108
changed the title
sangwoo108
force-pushed
the
sko/midnight
branch
2 times, most recently
from
64ecc00 to
6d48523
Compare
This commit introduces the Brave Midnight theme, a darker variant of the
existing dark theme, providing users with enhanced customization options
for their browsing experience.
Key changes:
* Add feature flag `kBraveMidnightTheme` to control theme availability
* Create new preference `kBraveDarkerMode` to store user's theme choice
* Implement UI toggle in Customize Chrome side panel for theme switching
* Add Mojo interface methods for theme state management
Technical implementation:
- Created `browser/ui/color/features.{cc,h}` for feature flag definition
- Added feature flag to `about_flags.cc` for experimental access
- Registered preference in `brave_profile_prefs.cc` when feature is enabled
- Extended Customize Chrome UI with `DarkerThemeToggle` component
- Added Mojo interface methods `GetUseDarkerTheme`/`SetUseDarkerTheme`
The feature is disabled by default and can be enabled via the
`brave-midnight-theme` flag in brave://flags. When enabled, users can
toggle the darker theme through the Customize Chrome side panel.
sangwoo108
force-pushed
the
sko/midnight
branch
from
6d48523 to
e67331e
Compare
|
A Storybook has been deployed to preview UI for the latest push |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the Brave Midnight theme, a darker variant of the existing dark theme, providing users with enhanced customization options for their browsing experience.
Key changes:
kBraveMidnightThemeto control theme availabilitykBraveDarkerModeto store user's theme choiceTechnical implementation:
browser/ui/color/features.{cc,h}for feature flag definitionabout_flags.ccfor experimental accessbrave_profile_prefs.ccwhen feature is enabledDarkerThemeTogglecomponentGetUseDarkerTheme/SetUseDarkerThemeThe feature is disabled by default and can be enabled via the
brave-midnight-themeflag in brave://flags. When enabled, users can toggle the darker theme through the Customize Chrome side panel.Resolves brave/brave-browser#48192
Resolves brave/brave-browser#48193