Upgrade from Chromium 140 to Chromium 141 #30537
Draft
+602
−464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change corrects our patching for `RealtimeAnalyser`, to match the new configuration of the code, while still having the same effect. Chromium changes: https://chromium.googlesource.com/chromium/src/+/0f97e77ac0172f23485dc673d1a4e0b63998074a commit 0f97e77ac0172f23485dc673d1a4e0b63998074a Author: Michael Wilson <[email protected]> Date: Tue Aug 5 10:29:37 2025 -0700 Minor cleanup in RealtimeAnalyser This CL performs some minor cleanup and coding standard compliance changes, in order to make the code easier to read and modify safely. This CL should not cause any functional changes. The following was done: - Reduce scope of some constants - Use default member initializers when possible - Standardize function order in header - Use magnitude_buffer_ directly instead of private member function - Add const and constexpr when possible - Invert conditionals to allow inlining two functions Change-Id: I45d7b6e6c3b9b9c2ad46502f51388ea4218ee261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3953855 Reviewed-by: Alvin Ji <[email protected]> Commit-Queue: Michael Wilson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1497012}
Upstream does not have a running bot for `enable_glic` as `false`, so most of the time things break on as we are building on our end. This is a cherry-pick of a fix submitted by us. Chromium changes: https://chromium.googlesource.com/chromium/src/+/1ab4d52331a1431cb4da90be05db180b1acf2240 commit 1ab4d52331a1431cb4da90be05db180b1acf2240 Author: Claudio DeSouza <[email protected]> Date: Wed Aug 6 14:34:19 2025 +0100 Guard glic deps with enable_glic for whats-new This is a follow up to https://crrev.com/c/6820118, as it introduce `//chrome/browser/glic`, however that target is supposed to be guarded with `enable_glic`. Bug: 430325799 Change-Id: Ia4cde2ca83e2380dc8b4fbea10b255b510347c80
Chromium changes: https://chromium.googlesource.com/chromium/src/+/882390718fb07923d842e4d50886bbac7b0b57ac commit 882390718fb07923d842e4d50886bbac7b0b57ac Author: Devlin Cronin <[email protected]> Date: Tue Aug 5 11:04:21 2025 -0700 [Extensions] Remove kExtensionManifestV2DeprecationWarning Remove the kExtensionManifestV2DeprecationWarning base::Feature. This was launched by default last July in M128, so can be safely removed. This CL simply removes the feature and any effectively-dead code (any code conditional on the feature being false). It also removes the MV2ExperimentStage::kNone entry, since this is now effectively unreachable (every user is in at least the kWarn stage). We can *also* remove a lot of the functionality here, because we only warn users once, and only if they aren't in a higher experiment stage. However, that clean up will come later. This ensures this CL remains an effective no-op for any Chromium users. Bug: 431097630 Change-Id: I591331297598e2340721f01b769e2dd7859443fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6771668 Reviewed-by: Emilia Paz <[email protected]> Commit-Queue: Devlin Cronin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1497036}
Chromium changes: https://chromium.googlesource.com/chromium/src/+/23254c17256979079cb89edee2b0602f0b22902e commit 23254c17256979079cb89edee2b0602f0b22902e Author: Caroline Rising <[email protected]> Date: Tue Aug 5 10:36:54 2025 -0700 [SxS] Move devtools to ContentsContainerView supporting side-by-side. Move devtools related views from being created in browser_view.cc and its layout managed by ContentsLayoutManager to being owned and laid out by ContentsContainerView. This also creates a new controller for devtools to manage updating devtools on web contents attach/detach so that devtools can be updated even if the active tab does not change. Update browserview accessible panes to include both devtools and contents web views if in a split. splitview screenshot: https://screenshot.googleplex.com/BzJgCX36fP52can Bug: 415071842 Change-Id: Ic6000cdb4ec14876e92e669b2f5682616f8515cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6771055 Reviewed-by: Eshwar Stalin <[email protected]> Reviewed-by: Alex Rudenko <[email protected]> Reviewed-by: Danil Somsikov <[email protected]> Commit-Queue: Caroline Rising <[email protected]> Cr-Commit-Position: refs/heads/main@{#1497017}
This function added an argument to its arglist. This is not important to our use, but the argument has to be passed along in the override. Chromium changes: https://chromium.googlesource.com/chromium/src/+/f8a27e62c39a1e19e7de19f52f88cfac8c03665b commit f8a27e62c39a1e19e7de19f52f88cfac8c03665b Author: Gustavo Martin <[email protected]> Date: Tue Aug 5 09:38:44 2025 -0700 [Reading mode] Add UKM metrics for ReadAnything SidePanel Shown/Closed This change introduces new UKM (Url-Keyed Metrics) to track when the Read Anything side panel is opened and closed. Needed to understand which pages are most commonly accessed through reading mode and design an immersive experience for it. These metrics are being added as a separate, reading mode-specific UKM event to ensure that URL-keyed data is only collected for the reading mode feature and avoid unnecessary metric collection. UKM Review Doc: https://docs.google.com/document/d/1qzyoK3wWKTXWkPtMty_q7HYaZxROI9tf99NLDJiYeYM/edit?resourcekey=0-RBLeeim2LcSyVyxrJH43Kg&tab=t.0#heading=h.k5jx6iluw4yt Bug: 430962039 Change-Id: I8aa2609d23ba4c3d0c4dd9d2cd07282e433d319c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6774204 Reviewed-by: Alexei Svitkine <[email protected]> Commit-Queue: Gustavo Martin <[email protected]> Reviewed-by: Caroline Rising <[email protected]> Reviewed-by: Lauren Winston <[email protected]> Cr-Commit-Position: refs/heads/main@{#1496979}
This override is used to skip `@gemini`, however it was relying on a lot of surrounding context, which is always not very reliable. This change makes use of a patchfile to anchor the override. Chromium changes: https://chromium.googlesource.com/chromium/src/+/8c8581d518cc644e096504d00cded092a045a311 commit 8c8581d518cc644e096504d00cded092a045a311 Author: manukh <[email protected]> Date: Tue Aug 5 11:26:43 2025 -0700 [omnibox][toolbelt] Guard AI Mode starter pack Toolbelt AI mode is guarded by 4 requirements: 1) toolbelt feature & AI mode params are enabled 2) DSE is google 3) locale is en-US 4) AI Mode policy setting is enabled Starter pack AI mode (e.g. when user types '@' or '@aimode') is not guarded. It should have the same 4 guards. Except (1) should be guarded by just the toolbelt feature, and not by the AI Mode NTP/web/SRP params. Each toolbelt action has a param for whether it'll be shown on NTP and another param for whether it'll be shown on web/SRP. Those aren't necessary for @aimode starter pack. We show the other starter packs regardless of current webpage context. If the user takes the effort to type out '@aimode', it would be unpleasant to hide it from them. Bug: 431283497, 436225340 Change-Id: Ifdf3d6437e6b21405a8a40e71da097607bf166c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6729947 Reviewed-by: Ryan Sultanem <[email protected]> Auto-Submit: manuk hovanesian <[email protected]> Reviewed-by: Robbie Gibson <[email protected]> Reviewed-by: Moe Ahmadi <[email protected]> Commit-Queue: Robbie Gibson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1497056}
This change removes the patch cherry-picking this fix that had to be submitted upstream for a glic breakage. Chromium changes: https://chromium.googlesource.com/chromium/src/+/1a8bdc4f2b9d9b5b57d90d5397a05761631527b9 commit 1a8bdc4f2b9d9b5b57d90d5397a05761631527b9 Author: Claudio DeSouza <[email protected]> Date: Wed Aug 6 07:59:29 2025 -0700 Guard glic deps with enable_glic for whats-new This is a follow up to https://crrev.com/c/6820118, as it introduce `//chrome/browser/glic`, however that target is supposed to be guarded with `enable_glic`. Bug: 430325799 Change-Id: Ia4cde2ca83e2380dc8b4fbea10b255b510347c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822745 Reviewed-by: Mickey Burks <[email protected]> Commit-Queue: Claudio DeSouza <[email protected]> Cr-Commit-Position: refs/heads/main@{#1497594}
Chromium changes: https://chromium.googlesource.com/chromium/src/+/83c9c42e855f2a9a762ee9416f7351f6bad3d1ec commit 83c9c42e855f2a9a762ee9416f7351f6bad3d1ec Author: Robert Lin <[email protected]> Date: Tue Aug 5 18:36:55 2025 -0700 Clean up features::kBookmarkTriggerForPrerender2 and introduce features::kBookmarkTriggerForPrerender2KillSwitch This CL does 1. Remove `features::kBookmarkTriggerForPrerender2` as the feature has been enabled by default. And it is no longer needed. 2. With removal of the feature flag, it is still desired to have a kill switch to have a way to disable in case of emergency. `features::kBookmarkTriggerForPrerender2KillSwitch` is introduced in `BookmarkBarPreloadPipeline::StartPrerender` to do so. Bug: 40259793 Change-Id: I2af922338277e25aa3a868a8139da59929dd624d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6818916 Commit-Queue: Huanpo Lin <[email protected]> Reviewed-by: Marc Treib <[email protected]> Cr-Commit-Position: refs/heads/main@{#1497309}
With a lot of places forward-declaring this `View`, this has caused one of its transitive inclusion to start giving build errors in a few places. Chromium changes: https://chromium.googlesource.com/chromium/src/+/68d8b9d8182cf5aad601cf7b6df58c72089cfd85 commit 68d8b9d8182cf5aad601cf7b6df58c72089cfd85 Author: David Sanders <[email protected]> Date: Tue Aug 5 23:03:30 2025 -0700 Replace includes with forward declares in //ui/views/view.h Should save ~131 MiB of compiler input size. Adds missing includes as needed to fix the build. Bug: 429365675 Change-Id: Idee135b4ba61f47469825060e38fb06a8cc8f8b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6820642 Owners-Override: Lei Zhang <[email protected]> Reviewed-by: Lei Zhang <[email protected]> Commit-Queue: Lei Zhang <[email protected]> Cr-Commit-Position: refs/heads/main@{#1497372}
Chromium changes: https://chromium.googlesource.com/chromium/src/+/5bb74b89d4749927ce8f2e10a04d99903bba677c commit 5bb74b89d4749927ce8f2e10a04d99903bba677c Author: Chris Thompson <[email protected]> Date: Wed Aug 6 15:01:47 2025 -0700 [HFM] Add new Ask-before-HTTP dialog UI This adds AskBeforeHttpDialogController which is responsible for defining the dialog model, owning the resulting dialog widget, and tracking dialog events for a new "Ask-before-HTTP" warning dialog. The controller itself is owned by the TabFeatures class and is instantiated on a per-tab basis. The actual dialog itself is created using a DialogModel, hosted in a BubbleDialogModelHost, and presented via TabDialogManager. As part of this effort, this CL refactors out some shared logic ( ComputeInterstitialState()) and exposes some other logic for reuse (such as GetInterstitialReason()) so they can be reused across the two UIs. A new interactive UI test suite is added to explicitly test the dialog UI and the different actions there-in. This intentionally somewhat overlaps with the existing browser tests in https_upgrades_browsertest.cc (which focuses more on the underlying HTTPS-Upgrades/fallback and navigation handling logic). See crbug.com/351990829#comment3 and crbug.com/351990829#comment3 for a recording and screenshot of how the new dialog UI looks. DanglingUntriaged-notes: Duplicate of existing test suite use Bug: 351990829 Change-Id: I7be11a749dd2e08cda362d5adca7b1e85ba792e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6817235 Reviewed-by: David Pennington <[email protected]> Reviewed-by: Joe DeBlasio <[email protected]> Reviewed-by: Mustafa Emre Acer <[email protected]> Commit-Queue: Chris Thompson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1497873}
Chromium changes: https://chromium.googlesource.com/chromium/src/+/0307e728703a96f6c86b35e705937e85821cde0d commit 0307e728703a96f6c86b35e705937e85821cde0d Author: Patrick Meenan <[email protected]> Date: Wed Aug 6 09:05:19 2025 -0700 Updated origin for captive portal detection This changes the URL used for captive portal detection from http://www.gstatic.com/generate_204 to http://connectivitycheck.gstatic.com/generate_204 The change is necessary to allow for deploying HTTPS DNS records for www.gstatic.com which is used for a lot of web resources. The connectivitycheck domain is dedicated for captive portal detection and already in use by Android and Chromecast. The teams that own and run both origins have been consulted and have approved the change. The actual change is in components/captive_portal/core. The rest of the changes are to switch from using a global static string to a static method that can leverage the field trial support to slowly roll out the change. Bug: 383118221 Change-Id: I2332c3d90a6f6c69dff8189c674b506119b4a27e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6775730 Reviewed-by: Nico Weber <[email protected]> Reviewed-by: Rohit Rao <[email protected]> Commit-Queue: Patrick Meenan <[email protected]> Reviewed-by: Adam Rice <[email protected]> Reviewed-by: Kyle Horimoto <[email protected]> Cr-Commit-Position: refs/heads/main@{#1497637}
cdesouza-chromium
added
CI/run-network-audit
It was removed in enabled state, so no changes are required. Chromium changes: https://chromium.googlesource.com/chromium/src/+/3cffdcd19d2d679c16e7788fa1678c5fe0956e41 commit 3cffdcd19d2d679c16e7788fa1678c5fe0956e41 Author: David Black <[email protected]> Date: Tue Aug 5 17:17:39 2025 -0700 Clean up launched `RetainOmniboxOnFocus` feature flag. This CL cleans up the launched `RetainOmniboxOnFocus` feature flag. The feature launched in M136 (https://crrev.com/c/6335041). Bug: 427497741 Change-Id: I9b4afad2542b3fbae1fe1f566a5d574feff91e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6821558 Reviewed-by: Tomasz Wiszkowski <[email protected]> Commit-Queue: David Black <[email protected]> Cr-Commit-Position: refs/heads/main@{#1497278}
Chromium changes: https://chromium.googlesource.com/chromium/src/+/4ba632db1601435a435daa1578887efc26061e39 commit 4ba632db1601435a435daa1578887efc26061e39 Author: Liza Bipin <[email protected]> Date: Wed Aug 6 08:53:51 2025 -0700 [Signin][Android]Remove duplicated code in SystemAccountManagerDelegate Rename the class to be more reflective of current implementation. See crbug.com/429143376#comment3 for more context. Bug: 429143376 Change-Id: I7883533dd7edc61516f24064bb457eb23752e10e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6818502 Commit-Queue: Liza Bipin <[email protected]> Reviewed-by: Boris Sazonov <[email protected]> Reviewed-by: Liza Bipin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1497626}
This is actually a simplification, and this change aligns our use.
Chromium changes: https://chromium.googlesource.com/chromium/src/+/a3ae3847577b7918b8a6084f10309407a53294e5 commit a3ae3847577b7918b8a6084f10309407a53294e5 Author: quacksort <[email protected]> Date: Tue Aug 5 06:47:10 2025 -0700 [Signin][Android] Pass PrefService in SigninManagerImpl constructor This makes the PrefService dependency more explicit. This CL is a follow-up to this comment: https://crrev.com/c/6759932/7..10/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManagerImpl.java#b165 Bug: 404801135 Change-Id: I94c8638db320227d45515b5e7f4dffe19a0d5934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6781187 Reviewed-by: Menghan Yang <[email protected]> Commit-Queue: Lucia Giorgi <[email protected]> Cr-Commit-Position: refs/heads/main@{#1496885}
|
A Storybook has been deployed to preview UI for the latest push |
…e flag It was removed in enabled state, so no changes are required. Chromium changes: https://chromium.googlesource.com/chromium/src/+/3cffdcd19d2d679c16e7788fa1678c5fe0956e41 commit 3cffdcd19d2d679c16e7788fa1678c5fe0956e41 Author: David Black <[email protected]> Date: Tue Aug 5 17:17:39 2025 -0700 Clean up launched `RetainOmniboxOnFocus` feature flag. This CL cleans up the launched `RetainOmniboxOnFocus` feature flag. The feature launched in M136 (https://crrev.com/c/6335041). Bug: 427497741 Change-Id: I9b4afad2542b3fbae1fe1f566a5d574feff91e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6821558 Reviewed-by: Tomasz Wiszkowski <[email protected]> Commit-Queue: David Black <[email protected]> Cr-Commit-Position: refs/heads/main@{#1497278}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#48214