[AI Chat]: Fix Suggested Questions Overlapping Menu #30538
+39
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Douglashdaniel
force-pushed
the
ai-chat-fix-suggested-questions-overlapping-menu
branch
from
5c3aaef to
149a9db
Compare
github-actions
bot
added
the
CI/storybook-url
Comment on lines
+131
to
+132
| '--iframe-position-for-menus', | ||
| isOpen ? 'relative' : 'unset', |
There was a problem hiding this comment.
hey, could we not just set this to relative always and get rid of the mojom interface?
There was a problem hiding this comment.
Unfortunately no otherwise the iframe wrapper then overlaps the Suggested Question buttons and they become un-clickable.
There was a problem hiding this comment.
Aaah, so basically we need to pull the iframe to the top when its showing a menu. Okay, I guess that kind of makes sense.
Maaaaan iframes make everything hard 😆
fallaciousreasoning
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a style bug where the
Suggested Questionbuttons would sometimes overlap theRegenerate Answermenu.Resolves brave/brave-browser#48256
Test Plan:
Leoai with aTabattached to the questionRegenerate AnswermenuSuggested Questionsshould not overlap theMenuBefore:
After: