Skip to content

[Tabs]: Adds a tabs component #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[Tabs]: Adds a tabs component #1132

wants to merge 5 commits into from

Conversation

aguscruiz
Copy link
Collaborator

Copy link
Contributor

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://1132.pr.nala.bravesoftware.com/
✅ Commit preview: https://1132.pr.nala.bravesoftware.com/commit-d989b06dcfaca349f2de03d24a200316e8c1a400/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6644 bytes
+ ./tokens/css/variables-browser.css: 6644 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 893 bytes
+ ./tokens/css/variables-web3.css: 893 bytes
---
- ./tokens/css/variables.old.css: 121716 bytes
+ ./tokens/css/variables.css: 121716 bytes
Variables Diff: variables-android.diff
--- ./tokens/css/variables-android.old.css	2025-06-20 20:47:43.177174912 +0000
+++ ./tokens/css/variables-android.css	2025-06-20 20:47:06.971978217 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Jun 20 2025 11:11:06 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 20 2025 20:47:06 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-browser.diff
--- ./tokens/css/variables-browser.old.css	2025-06-20 20:47:43.414176832 +0000
+++ ./tokens/css/variables-browser.css	2025-06-20 20:47:06.959977989 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Jun 20 2025 11:11:06 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 20 2025 20:47:06 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-ios.diff
--- ./tokens/css/variables-ios.old.css	2025-06-20 20:47:43.679178980 +0000
+++ ./tokens/css/variables-ios.css	2025-06-20 20:47:06.995978674 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Jun 20 2025 11:11:06 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 20 2025 20:47:06 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-marketing.diff
--- ./tokens/css/variables-marketing.old.css	2025-06-20 20:47:44.017181717 +0000
+++ ./tokens/css/variables-marketing.css	2025-06-20 20:47:07.012978997 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Jun 20 2025 11:11:06 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 20 2025 20:47:07 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-news.diff
--- ./tokens/css/variables-news.old.css	2025-06-20 20:47:44.240183527 +0000
+++ ./tokens/css/variables-news.css	2025-06-20 20:47:07.033979397 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Jun 20 2025 11:11:06 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 20 2025 20:47:07 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-newtab.diff
--- ./tokens/css/variables-newtab.old.css	2025-06-20 20:47:44.513185736 +0000
+++ ./tokens/css/variables-newtab.css	2025-06-20 20:47:07.041979549 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Jun 20 2025 11:11:06 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 20 2025 20:47:07 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-search.diff
--- ./tokens/css/variables-search.old.css	2025-06-20 20:47:44.829188299 +0000
+++ ./tokens/css/variables-search.css	2025-06-20 20:47:07.029979321 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Jun 20 2025 11:11:06 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 20 2025 20:47:07 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-web3.diff
--- ./tokens/css/variables-web3.old.css	2025-06-20 20:47:45.050190089 +0000
+++ ./tokens/css/variables-web3.css	2025-06-20 20:47:07.045979625 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Jun 20 2025 11:11:06 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 20 2025 20:47:07 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {
Variables Diff: variables.diff
--- ./tokens/css/variables.old.css	2025-06-20 20:47:45.402192943 +0000
+++ ./tokens/css/variables.css	2025-06-20 20:47:06.833975592 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Jun 20 2025 11:11:06 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 20 2025 20:47:06 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

@fallaciousreasoning fallaciousreasoning changed the title creation of tabs component [Tabs]: Adds a tabs component Jun 22, 2025

const activeTab = getContext<Writable<number>>('activeTab')
const tabs = getContext<{ add: (tab: any) => number, registerElement: (index: number, element: HTMLElement) => void }>('tabs')
const size = getContext<TabSize>('size')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately we can't use Svelte's context in our WebComponents 😢 We might need to have a think about how best to approach this :/

@petemill
Copy link
Member

Let's make the following changes:

  • Don't accept tab panel content. The component should only deal with the tab UI itself
  • Model the parameters exactly after segmentedControl.svelte, including using child slot elements
  • Don't use svelte context

Copy link
Contributor

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://1132.pr.nala.bravesoftware.com/
✅ Commit preview: https://1132.pr.nala.bravesoftware.com/commit-20c4dd4706941db5b1d0dc33198140e54a51aaf9/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6644 bytes
+ ./tokens/css/variables-browser.css: 6644 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 893 bytes
+ ./tokens/css/variables-web3.css: 893 bytes
---
- ./tokens/css/variables.old.css: 121716 bytes
+ ./tokens/css/variables.css: 121716 bytes
Variables Diff: variables-android.diff
--- ./tokens/css/variables-android.old.css	2025-06-26 22:59:59.815414375 +0000
+++ ./tokens/css/variables-android.css	2025-06-26 22:59:23.848079815 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 26 2025 12:34:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Jun 26 2025 22:59:23 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-browser.diff
--- ./tokens/css/variables-browser.old.css	2025-06-26 23:00:00.106417239 +0000
+++ ./tokens/css/variables-browser.css	2025-06-26 22:59:23.836079706 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 26 2025 12:34:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Jun 26 2025 22:59:23 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-ios.diff
--- ./tokens/css/variables-ios.old.css	2025-06-26 23:00:00.440420572 +0000
+++ ./tokens/css/variables-ios.css	2025-06-26 22:59:23.864079959 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 26 2025 12:34:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Jun 26 2025 22:59:23 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-marketing.diff
--- ./tokens/css/variables-marketing.old.css	2025-06-26 23:00:00.764423808 +0000
+++ ./tokens/css/variables-marketing.css	2025-06-26 22:59:23.884080140 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 26 2025 12:34:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Jun 26 2025 22:59:23 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-news.diff
--- ./tokens/css/variables-news.old.css	2025-06-26 23:00:01.099427151 +0000
+++ ./tokens/css/variables-news.css	2025-06-26 22:59:23.916080430 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 26 2025 12:34:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Jun 26 2025 22:59:23 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-newtab.diff
--- ./tokens/css/variables-newtab.old.css	2025-06-26 23:00:01.403430182 +0000
+++ ./tokens/css/variables-newtab.css	2025-06-26 22:59:23.923080493 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 26 2025 12:34:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Jun 26 2025 22:59:23 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-search.diff
--- ./tokens/css/variables-search.old.css	2025-06-26 23:00:01.716433306 +0000
+++ ./tokens/css/variables-search.css	2025-06-26 22:59:23.911080385 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 26 2025 12:34:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Jun 26 2025 22:59:23 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-web3.diff
--- ./tokens/css/variables-web3.old.css	2025-06-26 23:00:01.998436122 +0000
+++ ./tokens/css/variables-web3.css	2025-06-26 22:59:23.927080530 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 26 2025 12:34:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Jun 26 2025 22:59:23 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {
Variables Diff: variables.diff
--- ./tokens/css/variables.old.css	2025-06-26 23:00:02.332439453 +0000
+++ ./tokens/css/variables.css	2025-06-26 22:59:23.700078023 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 26 2025 12:34:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Jun 26 2025 22:59:23 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Copy link
Contributor

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://1132.pr.nala.bravesoftware.com/
✅ Commit preview: https://1132.pr.nala.bravesoftware.com/commit-5b1778720ca23e6229d8e8532f5831d3286070b9/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6644 bytes
+ ./tokens/css/variables-browser.css: 6644 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 893 bytes
+ ./tokens/css/variables-web3.css: 893 bytes
---
- ./tokens/css/variables.old.css: 121716 bytes
+ ./tokens/css/variables.css: 121716 bytes
Variables Diff: variables-android.diff
--- ./tokens/css/variables-android.old.css	2025-06-27 11:55:16.631768266 +0000
+++ ./tokens/css/variables-android.css	2025-06-27 11:54:40.779177471 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 26 2025 12:34:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 27 2025 11:54:40 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-browser.diff
--- ./tokens/css/variables-browser.old.css	2025-06-27 11:55:16.948763805 +0000
+++ ./tokens/css/variables-browser.css	2025-06-27 11:54:40.766177606 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 26 2025 12:34:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 27 2025 11:54:40 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-ios.diff
--- ./tokens/css/variables-ios.old.css	2025-06-27 11:55:17.276759191 +0000
+++ ./tokens/css/variables-ios.css	2025-06-27 11:54:40.801177242 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 26 2025 12:34:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 27 2025 11:54:40 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-marketing.diff
--- ./tokens/css/variables-marketing.old.css	2025-06-27 11:55:17.589754788 +0000
+++ ./tokens/css/variables-marketing.css	2025-06-27 11:54:40.818177065 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 26 2025 12:34:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 27 2025 11:54:40 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-news.diff
--- ./tokens/css/variables-news.old.css	2025-06-27 11:55:17.892750523 +0000
+++ ./tokens/css/variables-news.css	2025-06-27 11:54:40.840176836 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 26 2025 12:34:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 27 2025 11:54:40 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-newtab.diff
--- ./tokens/css/variables-newtab.old.css	2025-06-27 11:55:18.192746299 +0000
+++ ./tokens/css/variables-newtab.css	2025-06-27 11:54:40.847176763 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 26 2025 12:34:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 27 2025 11:54:40 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-search.diff
--- ./tokens/css/variables-search.old.css	2025-06-27 11:55:18.490742108 +0000
+++ ./tokens/css/variables-search.css	2025-06-27 11:54:40.836176877 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 26 2025 12:34:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 27 2025 11:54:40 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-web3.diff
--- ./tokens/css/variables-web3.old.css	2025-06-27 11:55:18.835737251 +0000
+++ ./tokens/css/variables-web3.css	2025-06-27 11:54:40.851176721 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 26 2025 12:34:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 27 2025 11:54:40 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {
Variables Diff: variables.diff
--- ./tokens/css/variables.old.css	2025-06-27 11:55:19.307730609 +0000
+++ ./tokens/css/variables.css	2025-06-27 11:54:40.626179064 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Jun 26 2025 12:34:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Jun 27 2025 11:54:40 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

@petemill
Copy link
Member

petemill commented Aug 7, 2025

I pushed a rebase @aguscruiz

Copy link
Contributor

github-actions bot commented Aug 7, 2025

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://1132.pr.nala.bravesoftware.com/
✅ Commit preview: https://1132.pr.nala.bravesoftware.com/commit-b2953097523c92d38d94a906b71dd893a68df2d4/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6644 bytes
+ ./tokens/css/variables-browser.css: 6644 bytes
---
- ./tokens/css/variables-ios.old.css: 8180 bytes
+ ./tokens/css/variables-ios.css: 8180 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 893 bytes
+ ./tokens/css/variables-web3.css: 893 bytes
---
- ./tokens/css/variables.old.css: 124825 bytes
+ ./tokens/css/variables.css: 124825 bytes
Variables Diff: variables-android.diff
--- ./tokens/css/variables-android.old.css	2025-08-07 09:57:01.315467380 +0000
+++ ./tokens/css/variables-android.css	2025-08-07 09:56:24.991190282 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 06 2025 14:26:57 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Aug 07 2025 09:56:24 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-browser.diff
--- ./tokens/css/variables-browser.old.css	2025-08-07 09:57:01.576469398 +0000
+++ ./tokens/css/variables-browser.css	2025-08-07 09:56:24.979190192 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 06 2025 14:26:57 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Aug 07 2025 09:56:24 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-ios.diff
--- ./tokens/css/variables-ios.old.css	2025-08-07 09:57:01.677470179 +0000
+++ ./tokens/css/variables-ios.css	2025-08-07 09:56:25.015190463 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 06 2025 14:26:57 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Aug 07 2025 09:56:25 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-marketing.diff
--- ./tokens/css/variables-marketing.old.css	2025-08-07 09:57:01.828471348 +0000
+++ ./tokens/css/variables-marketing.css	2025-08-07 09:56:25.032190591 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 06 2025 14:26:57 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Aug 07 2025 09:56:25 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-news.diff
--- ./tokens/css/variables-news.old.css	2025-08-07 09:57:01.996472645 +0000
+++ ./tokens/css/variables-news.css	2025-08-07 09:56:25.054190756 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 06 2025 14:26:57 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Aug 07 2025 09:56:25 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-newtab.diff
--- ./tokens/css/variables-newtab.old.css	2025-08-07 09:57:02.186577791 +0000
+++ ./tokens/css/variables-newtab.css	2025-08-07 09:56:25.061190809 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 06 2025 14:26:57 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Aug 07 2025 09:56:25 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-search.diff
--- ./tokens/css/variables-search.old.css	2025-08-07 09:57:02.328697154 +0000
+++ ./tokens/css/variables-search.css	2025-08-07 09:56:25.049190719 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 06 2025 14:26:57 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Aug 07 2025 09:56:25 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-web3.diff
--- ./tokens/css/variables-web3.old.css	2025-08-07 09:57:02.498840054 +0000
+++ ./tokens/css/variables-web3.css	2025-08-07 09:56:25.065190839 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 06 2025 14:26:57 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Aug 07 2025 09:56:25 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {
Variables Diff: variables.diff
--- ./tokens/css/variables.old.css	2025-08-07 09:57:02.707014896 +0000
+++ ./tokens/css/variables.css	2025-08-07 09:56:24.839189139 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 06 2025 14:26:57 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Aug 07 2025 09:56:24 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

@petemill
Copy link
Member

petemill commented Aug 7, 2025

fixed scroll bar issue

Copy link
Contributor

github-actions bot commented Aug 7, 2025

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://1132.pr.nala.bravesoftware.com/
✅ Commit preview: https://1132.pr.nala.bravesoftware.com/commit-1bd9be105b6e374fca1c6dd3df5c93b41354d07b/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6644 bytes
+ ./tokens/css/variables-browser.css: 6644 bytes
---
- ./tokens/css/variables-ios.old.css: 8180 bytes
+ ./tokens/css/variables-ios.css: 8180 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 893 bytes
+ ./tokens/css/variables-web3.css: 893 bytes
---
- ./tokens/css/variables.old.css: 124825 bytes
+ ./tokens/css/variables.css: 124825 bytes
Variables Diff: variables-android.diff
--- ./tokens/css/variables-android.old.css	2025-08-07 22:56:55.766608646 +0000
+++ ./tokens/css/variables-android.css	2025-08-07 22:56:20.850480887 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 06 2025 14:26:57 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Aug 07 2025 22:56:20 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-browser.diff
--- ./tokens/css/variables-browser.old.css	2025-08-07 22:56:56.005609679 +0000
+++ ./tokens/css/variables-browser.css	2025-08-07 22:56:20.836481696 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 06 2025 14:26:57 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Aug 07 2025 22:56:20 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-ios.diff
--- ./tokens/css/variables-ios.old.css	2025-08-07 22:56:56.223610624 +0000
+++ ./tokens/css/variables-ios.css	2025-08-07 22:56:20.864480077 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 06 2025 14:26:57 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Aug 07 2025 22:56:20 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-marketing.diff
--- ./tokens/css/variables-marketing.old.css	2025-08-07 22:56:56.462611658 +0000
+++ ./tokens/css/variables-marketing.css	2025-08-07 22:56:20.880479152 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 06 2025 14:26:57 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Aug 07 2025 22:56:20 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-news.diff
--- ./tokens/css/variables-news.old.css	2025-08-07 22:56:56.681612608 +0000
+++ ./tokens/css/variables-news.css	2025-08-07 22:56:20.902477880 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 06 2025 14:26:57 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Aug 07 2025 22:56:20 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-newtab.diff
--- ./tokens/css/variables-newtab.old.css	2025-08-07 22:56:56.895613534 +0000
+++ ./tokens/css/variables-newtab.css	2025-08-07 22:56:20.909477475 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 06 2025 14:26:57 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Aug 07 2025 22:56:20 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-search.diff
--- ./tokens/css/variables-search.old.css	2025-08-07 22:56:57.099614418 +0000
+++ ./tokens/css/variables-search.css	2025-08-07 22:56:20.898478111 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 06 2025 14:26:57 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Aug 07 2025 22:56:20 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-web3.diff
--- ./tokens/css/variables-web3.old.css	2025-08-07 22:56:57.347615492 +0000
+++ ./tokens/css/variables-web3.css	2025-08-07 22:56:20.913477243 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 06 2025 14:26:57 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Aug 07 2025 22:56:20 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {
Variables Diff: variables.diff
--- ./tokens/css/variables.old.css	2025-08-07 22:56:57.635616740 +0000
+++ ./tokens/css/variables.css	2025-08-07 22:56:20.702489446 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Aug 06 2025 14:26:57 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Aug 07 2025 22:56:20 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants