Skip to content

Commit ec19912

Browse files
authored
Merge pull request #94 from victormacko/master
Removed deprecations for PHP 8.4
2 parents f0cfa51 + 6167f05 commit ec19912

File tree

5 files changed

+8
-9
lines changed

5 files changed

+8
-9
lines changed

src/Service/EventBridge/EventBridgeTransport.php

-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
use Exception;
77
use Symfony\Component\Messenger\Envelope;
88
use Symfony\Component\Messenger\Exception\TransportException;
9-
use Symfony\Component\Messenger\Transport\Serialization\PhpSerializer;
109
use Symfony\Component\Messenger\Transport\Serialization\SerializerInterface;
1110
use Symfony\Component\Messenger\Transport\TransportInterface;
1211
use Throwable;

src/Service/Sns/SnsConsumer.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ public function __construct(
2828
BusDriver $busDriver,
2929
MessageBusInterface $bus,
3030
SerializerInterface $serializer,
31-
string $transportName = null,
32-
SnsTransportNameResolver $transportNameResolver = null,
31+
?string $transportName = null,
32+
?SnsTransportNameResolver $transportNameResolver = null,
3333
) {
3434
$this->busDriver = $busDriver;
3535
$this->bus = $bus;

src/Service/Sns/SnsFifoStamp.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ class SnsFifoStamp implements NonSendableStampInterface {
88
private ?string $messageGroupId;
99
private ?string $messageDeduplicationId;
1010

11-
public function __construct(string $messageGroupId = null, string $messageDeduplicationId = null)
11+
public function __construct(?string $messageGroupId = null, ?string $messageDeduplicationId = null)
1212
{
1313
$this->messageGroupId = $messageGroupId;
1414
$this->messageDeduplicationId = $messageDeduplicationId;

src/Service/Sns/SnsTransport.php

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
use Exception;
88
use Symfony\Component\Messenger\Envelope;
99
use Symfony\Component\Messenger\Exception\TransportException;
10-
use Symfony\Component\Messenger\Transport\Serialization\PhpSerializer;
1110
use Symfony\Component\Messenger\Transport\Serialization\SerializerInterface;
1211
use Symfony\Component\Messenger\Transport\TransportInterface;
1312
use Throwable;

src/Service/Sqs/SqsConsumer.php

+5-4
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
namespace Bref\Symfony\Messenger\Service\Sqs;
44

5+
use Throwable;
56
use Bref\Context\Context;
67
use Bref\Event\Sqs\SqsEvent;
78
use Bref\Event\Sqs\SqsHandler;
@@ -39,10 +40,10 @@ public function __construct(
3940
BusDriver $busDriver,
4041
MessageBusInterface $bus,
4142
SerializerInterface $serializer,
42-
string $transportName = null,
43-
LoggerInterface $logger = null,
43+
?string $transportName = null,
44+
?LoggerInterface $logger = null,
4445
bool $partialBatchFailure = false,
45-
SqsTransportNameResolver $transportNameResolver = null
46+
?SqsTransportNameResolver $transportNameResolver = null
4647
) {
4748
$this->busDriver = $busDriver;
4849
$this->bus = $bus;
@@ -102,7 +103,7 @@ public function handleSqs(SqsEvent $event, Context $context): void
102103
} catch (UnrecoverableExceptionInterface $exception) {
103104
$this->logger->error(sprintf('SQS record with id "%s" failed to be processed. But failure was marked as unrecoverable. Message will be acknowledged.', $record->getMessageId()));
104105
$this->logger->error($exception);
105-
} catch (\Throwable $exception) {
106+
} catch (Throwable $exception) {
106107
if ($this->partialBatchFailure === false) {
107108
throw $exception;
108109
}

0 commit comments

Comments
 (0)