Fix remaining informational diagnostics.

Author: brian-reichle

src/TextTools/Format/FormatScanner.cs

@@ -11,9 +11,9 @@ public FormatScanner(ReadOnlySpan<char> format)
 			_format = format;
 			IsArgument = false;
 			_index = 0;
-			Text = ReadOnlySpan<char>.Empty;
-			ArgumentFormat = ReadOnlySpan<char>.Empty;
-			ArgumentAlignment = ReadOnlySpan<char>.Empty;
+			Text = [];
+			ArgumentFormat = [];
+			ArgumentAlignment = [];
 		}
 
 		public bool IsArgument { get; set; }
@@ -26,9 +26,9 @@ public bool MoveNext()
 			if (_index >= _format.Length)
 			{
 				IsArgument = false;
-				Text = ReadOnlySpan<char>.Empty;
-				ArgumentFormat = ReadOnlySpan<char>.Empty;
-				ArgumentAlignment = ReadOnlySpan<char>.Empty;
+				Text = [];
+				ArgumentFormat = [];
+				ArgumentAlignment = [];
 				return false;
 			}
 
@@ -46,7 +46,7 @@ public bool MoveNext()
 
 		static int ArgumentFormatLength(ReadOnlySpan<char> source)
 		{
-			ReadOnlySpan<char> braces = stackalloc char[] { '{', '}' };
+			ReadOnlySpan<char> braces = ['{', '}'];
 			var result = 0;
 
 			while (true)
@@ -80,7 +80,7 @@ static int ArgumentFormatLength(ReadOnlySpan<char> source)
 		bool MoveNextText()
 		{
 			var remaining = _format.Slice(_index);
-			var i = remaining.IndexOfAny(stackalloc char[] { '{', '}' });
+			var i = remaining.IndexOfAny(['{', '}']);
 
 			if (i < 0)
 			{
@@ -106,7 +106,7 @@ bool MoveNextText()
 		bool MoveNextArgument()
 		{
 			var remaining = _format.Slice(_index);
-			var i = remaining.IndexOfAny(stackalloc char[] { ',', ':', '}' });
+			var i = remaining.IndexOfAny([',', ':', '}']);
 
 			if (i < 0)
 			{
@@ -123,7 +123,7 @@ bool MoveNextArgument()
 			if (c == ',')
 			{
 				remaining = remaining.Slice(i + 1);
-				i = remaining.IndexOfAny(stackalloc char[] { ':', '}' });
+				i = remaining.IndexOfAny([':', '}']);
 
 				if (i < 0)
 				{
@@ -136,7 +136,7 @@ bool MoveNextArgument()
 			}
 			else
 			{
-				alignment = ReadOnlySpan<char>.Empty;
+				alignment = [];
 			}
 
 			ReadOnlySpan<char> format;
@@ -156,7 +156,7 @@ bool MoveNextArgument()
 			}
 			else
 			{
-				format = ReadOnlySpan<char>.Empty;
+				format = [];
 			}
 
 			SetArgument(arg, format, alignment);
@@ -167,8 +167,8 @@ void SetText(ReadOnlySpan<char> text)
 		{
 			Text = text;
 			IsArgument = false;
-			ArgumentFormat = ReadOnlySpan<char>.Empty;
-			ArgumentAlignment = ReadOnlySpan<char>.Empty;
+			ArgumentFormat = [];
+			ArgumentAlignment = [];
 		}
 
 		void SetArgument(ReadOnlySpan<char> arg, ReadOnlySpan<char> format, ReadOnlySpan<char> alignment)

src/TextTools/Format/FormatString.cs

@@ -13,7 +13,7 @@ public static class FormatString
 		public static bool ContainsEscapes(ReadOnlySpan<char> formatString, out int unescapedLength)
 		{
 			unescapedLength = formatString.Length;
-			ReadOnlySpan<char> braces = stackalloc char[] { '{', '}' };
+			ReadOnlySpan<char> braces = ['{', '}'];
 
 			var i = formatString.IndexOfAny(braces);
 
@@ -40,7 +40,7 @@ public static bool ContainsEscapes(ReadOnlySpan<char> formatString, out int unes
 
 		public static int WriteUnescaped(ReadOnlySpan<char> formatString, Span<char> unescaped)
 		{
-			ReadOnlySpan<char> braces = stackalloc char[] { '{', '}' };
+			ReadOnlySpan<char> braces = ['{', '}'];
 
 			var i = formatString.IndexOfAny(braces);
 			var length = 0;

src/TextTools/StringPool/StringPool.cs

@@ -94,7 +94,7 @@ public string GetString(ReadOnlySpan<char> text)
 			return result;
 		}
 
-		public StringPool Clone() => new StringPool(this);
+		public StringPool Clone() => new(this);
 
 		object ICloneable.Clone() => Clone();