Skip to content

Commit 7409d2c

Browse files
committed
bug fix: Color3/Color4 prop changes need assignment to run property setter code (ie: ColorPicker value).
1 parent d501907 commit 7409d2c

File tree

2 files changed

+2
-11
lines changed

2 files changed

+2
-11
lines changed

.vscode/launch.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"--timeout",
3131
"99999",
3232
"--colors",
33-
"${workspaceFolder}/test/**/*.spec.ts"
33+
"${workspaceFolder}/test/**/*.spec.{ts,tsx}"
3434
],
3535
"internalConsoleOptions": "openOnSessionStart",
3636
"name": "Mocha Tests",

src/UpdateInstance.ts

+1-10
Original file line numberDiff line numberDiff line change
@@ -31,16 +31,7 @@ export const applyUpdateToInstance = (hostInstance: any, update: PropertyUpdate)
3131
break;
3232
case PropChangeType.Color3:
3333
case PropChangeType.Color4:
34-
if (target[update.propertyName]) {
35-
switch (update.changeType) {
36-
case PropChangeType.Color3:
37-
(target[update.propertyName] as Color3).copyFrom(update.value);
38-
break;
39-
case PropChangeType.Color4:
40-
(target[update.propertyName] as Color4).copyFrom(update.value);
41-
break;
42-
}
43-
} else if (update.value) {
34+
if (update.value) {
4435
target[update.propertyName] = update.value.clone();
4536
} else {
4637
target[update.propertyName] = update.value;

0 commit comments

Comments
 (0)