Skip to content

Commit ca4a36e

Browse files
authored
feat(omnibar): support initial query and enhance alias expansion (#2360)
* feat(omnibar): enhance `expandAlias` on space key pressed, only match the part of input string before cursor for an alias, not the entire input string * feat(omnibar): support initial query for omnibar type `URLs`
1 parent c35875c commit ca4a36e

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

src/content_scripts/ui/omnibar.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,10 @@ function createOmnibar(front, clipboard) {
348348
handler.tabbed = self.tabbed ^ evt.shiftKey;
349349
handler.onEnter() && front.hidePopup();
350350
} else if (evt.keyCode === KeyboardUtils.keyCodes.space) {
351-
self.expandAlias(self.input.value, '') && evt.preventDefault();
351+
const cursor = self.input.selectionStart;
352+
const textBeforeCursor = self.input.value.substring(0, cursor);
353+
const newQuery = self.input.value.substring(cursor);
354+
self.expandAlias(textBeforeCursor, newQuery) && evt.preventDefault();
352355
} else if (evt.keyCode === KeyboardUtils.keyCodes.backspace) {
353356
self.collapseAlias() && evt.preventDefault();
354357
}
@@ -1043,6 +1046,9 @@ function OpenURLs(prompt, omnibar, queryFn) {
10431046
});
10441047
};
10451048
self.onOpen = function(arg) {
1049+
if (arg) {
1050+
omnibar.input.value = arg;
1051+
}
10461052
sequenceNumber = 0;
10471053
queryAndList();
10481054
};

0 commit comments

Comments
 (0)